Sign upLogin

peter/jsonapitest

View on GitHub
Star

Showing 27 of 33 total issues

Avoid too many return statements within this function.
Open

    return false;
Severity: Major
Found in lib/util.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return false;
    Severity: Major
    Found in lib/util.js - About 30 mins to fix

      Function prepareStringify has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      var prepareStringify = function(object) {
  if (isIterable(object)) {
    Object.keys(object).forEach(function(key) {
      var value = object[key];
      if (_.isRegExp(value)) {
      Severity: Minor
      Found in lib/util.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function assertValid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      var assertValid = function(positive, result) {
  if (positive) {
    return result.error_messages ? result.error_messages.length === 0 : result;
  } else {
    return result.error_messages ? result.error_messages.length > 0 : !result;
      Severity: Minor
      Found in lib/assert_helper.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function normalizeRequest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      var normalizeRequest = function(apiCall) {
  var request = apiCall.request;
  if (request) {
    if (request.url == null && request.path && request.base_url) {
      request.url = request.base_url + request.path;
      Severity: Minor
      Found in lib/api_call.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function end has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            end: function(suite, test, apiCall) {
        var request = apiCall.request,
            url = request.url,
            args = [
              '-i',
      Severity: Minor
      Found in lib/callbacks/curl.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function applyPattern has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      var applyPattern = function(value, response) {
  if (response == null) return undefined;
  var matchValue = (typeof response === 'object' ? JSON.stringify(response) : response);
  var match = new RegExp(value).exec(matchValue);
  if (match !== null) {
      Severity: Minor
      Found in lib/select_functions.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language