peterhudec/authomatic

View on GitHub
examples/gae/showcase/static/js/foundation/foundation.forms.js

Summary

Maintainability
D
2 days
Test Coverage

Function events has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    events : function () {
      var self = this;

      $(this.scope)
        .on('change.fndtn.forms', 'form.custom select:not([data-customforms="disabled"])', function (e) {
Severity: Major
Found in examples/gae/showcase/static/js/foundation/foundation.forms.js - About 3 hrs to fix

    File foundation.forms.js has 270 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*jslint unparam: true, browser: true, indent: 2 */
    
    ;(function ($, window, document, undefined) {
      'use strict';
    
    
    Severity: Minor
    Found in examples/gae/showcase/static/js/foundation/foundation.forms.js - About 2 hrs to fix

      Function append_custom_select has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          append_custom_select : function (idx, sel) {
            var self = Foundation.libs.forms,
                $this = $( sel ),
                $customSelect = $this.next( 'div.custom.dropdown' ),
                $customList = $customSelect.find( 'ul' ),
      Severity: Major
      Found in examples/gae/showcase/static/js/foundation/foundation.forms.js - About 2 hrs to fix

        Function refresh_custom_select has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            refresh_custom_select : function ($select) {
              var self = this;
              var maxWidth = 0,
                $customSelect = $select.next(),
                $options = $select.find('option');
        Severity: Minor
        Found in examples/gae/showcase/static/js/foundation/foundation.forms.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      } else if ($associatedElement.attr('type') === 'radio') {
                        e.preventDefault();
                        $customRadio = $(this).find('span.custom.radio');
                        //the radio might be outside after the label
                        if ($customRadio.length == 0) {
          examples/gae/showcase/static/js/foundation/foundation.forms.js on lines 56..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if ($associatedElement.attr('type') === 'checkbox') {
                        e.preventDefault();
                        $customCheckbox = $(this).find('span.custom.checkbox');
          
                        //the checkbox might be outside after the label
          examples/gae/showcase/static/js/foundation/foundation.forms.js on lines 69..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  liHtml = $options.map(function() { return "<li>" + $( this ).html() + "</li>"; } ).get().join( '' );
          examples/gae/showcase/static/js/foundation/foundation.forms.js on lines 196..199

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  liHtml = $options.map(function() {
                      return "<li>" + $( this ).html() + "</li>";
                    })
                    .get().join('');
          examples/gae/showcase/static/js/foundation/foundation.forms.js on lines 188..188

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status