pgeraghty/headless

View on GitHub

Showing 3 of 3 total issues

Method hook_at_exit has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def hook_at_exit
    unless @at_exit_hook_installed
      @at_exit_hook_installed = true
      at_exit do
        exit_status = $!.status if $!.is_a?(SystemExit)
Severity: Minor
Found in lib/headless.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pick_available_display has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def pick_available_display(display_set, can_reuse)
    display_set.each do |display_number|
      @display = display_number
      begin
        return true if xvfb_running? && can_reuse
Severity: Minor
Found in lib/headless.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method kill_process has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def self.kill_process(pid_filename, options={})
      options[:sig] ||= 'TERM'
      if pid = self.read_pid(pid_filename)
        begin
          Process.kill options[:sig], pid
Severity: Minor
Found in lib/headless/cli_util.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language