phallguy/scorpion

View on GitHub

Showing 7 of 9 total issues

Method execute_from_trip has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def execute_from_trip( trip )
        return unless obj = trip.object
        return obj if contract === obj

        # If we have already resolved an instance of this contract in this
Severity: Minor
Found in lib/scorpion/hunt.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method included has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.included( base ) # rubocop:disable Metrics/MethodLength
        # @!attribute [rw]
        # @return [Scorpion::Nest] the singleton nest used by controllers.
        base.class_attribute :nest_instance
        base.class_exec do
Severity: Minor
Found in lib/scorpion/rails/nest.rb - About 1 hr to fix

    Method inject_from has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def inject_from( dependencies, overwrite = false )
            injected_attributes.each do |attr|
              next unless dependencies.key? attr.name
    
              if overwrite || !send( "#{ attr.name }?" )
    Severity: Minor
    Found in lib/scorpion/object.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method inject_from! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def inject_from!( dependencies, overwrite = false )
            injected_attributes.each do |attr|
              next unless dependencies.key? attr.name
              val = dependencies.delete( attr.name )
    
    
    Severity: Minor
    Found in lib/scorpion/object.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method inject has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def inject( object )
          trip.object = object
          object.send :scorpion_hunt=, self
    
          object.injected_attributes.each do |attr|
    Severity: Minor
    Found in lib/scorpion/hunt.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method define has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def define( contract, options = {}, &builder )
            if options.key?( :return )
              Scorpion::Dependency::BuilderDependency.new( contract ) do
                options[:return]
              end
    Severity: Minor
    Found in lib/scorpion/dependency.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method assign_scorpion has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def assign_scorpion( object )
            return unless object.respond_to?( :scorpion=, true )
    
            # Only set scorpion if it hasn't been set yet.
            current_scorpion = object.send :scorpion
    Severity: Minor
    Found in lib/scorpion/stinger.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language