Sign upLogin

php-sap/saprfc-harding

View on GitHub
Star

Showing 4 of 10 total issues

Method invoke has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function invoke()
    {
        /**
         * Merge value and table parameters into one parameter array.
         */
Severity: Minor
Found in src/SapRfc.php - About 1 hr to fix

    Method getConnection has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function getConnection()
    {
        if ($this->connection === null) {
            /**
             * In case the is no configuration, throw an exception.
    Severity: Minor
    Found in src/SapRfc.php - About 1 hr to fix

      Function getFunction has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getFunction()
    {
        if ($this->function === null) {
            /**
             * Create a new function resource.
      Severity: Minor
      Found in src/SapRfc.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getConnection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getConnection()
    {
        if ($this->connection === null) {
            /**
             * In case the is no configuration, throw an exception.
      Severity: Minor
      Found in src/SapRfc.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language