Sign upLogin

pinclub/pinclub

View on GitHub
Star
controllers/github.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function create has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.create = function (req, res, next) {
    var profile = req.session.profile;

    var isnew = req.body.isnew;
    var loginname = validator.trim(req.body.name || '').toLowerCase();
Severity: Major
Found in controllers/github.js - About 2 hrs to fix

    Function callback has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.callback = function (req, res, next) {
    var profile = req.user;
    var email = profile.emails && profile.emails[0] && profile.emails[0].value;
    User.findOne({githubId: profile.id}, function (err, user) {
        if (err) {
    Severity: Minor
    Found in controllers/github.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              ep.on('login_error', function (login_error) {
            res.status(403);
            res.render('sign/signin', {error: '账号名或密码错误。', page: 'signin'});
        });
      Severity: Minor
      Found in controllers/github.js and 1 other location - About 50 mins to fix
      controllers/sign.js on lines 150..153

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status