Sign upLogin

pinclub/pinclub

View on GitHub
Star
controllers/node.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function create has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.create = function (req, res, next) {
    req.checkBody({
        'name': {
            notEmpty: {
                options: [true],
Severity: Minor
Found in controllers/node.js - About 1 hr to fix

    Function show has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.show = function (req, res, next) {
    req.checkParams({
        'id': {
            notEmpty: {
                options: [true],
    Severity: Minor
    Found in controllers/node.js - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          req.checkBody({
        'name': {
            notEmpty: {
                options: [true],
                errorMessage: '节点名称不能为空'
      Severity: Major
      Found in controllers/node.js and 3 other locations - About 1 hr to fix
      api/v2/auth.js on lines 160..173
      api/v2/image.js on lines 313..326
      controllers/sign.js on lines 193..206

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (!!data.id) {
            // 修改
            Node.getNode(data.id, function(err, forum) {
                if (err) {
                    return next(err);
      Severity: Minor
      Found in controllers/node.js and 1 other location - About 45 mins to fix
      controllers/forum.js on lines 47..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status