Sign upLogin

pinclub/pinclub

View on GitHub
Star
controllers/sign.js

Summary

Maintainability
D
1 day
Test Coverage

File sign.js has 307 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var validator = require('validator');
var EventProxy = require('eventproxy');
var config = require('../config');
var User = require('../proxy').User;
var mail = require('../common/mail');
Severity: Minor
Found in controllers/sign.js - About 3 hrs to fix

    Function signup has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.signup = function (req, res, next) {
    var loginname = validator.trim(req.body.loginname).toLowerCase();
    var email = validator.trim(req.body.email).toLowerCase();
    var pass = validator.trim(req.body.pass);
    var rePass = validator.trim(req.body.re_pass);
    Severity: Major
    Found in controllers/sign.js - About 2 hrs to fix

      Function login has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.login = function (req, res, next) {
    var loginname = validator.trim(req.body.name).toLowerCase();
    var pass = validator.trim(req.body.pass);
    var ep = new EventProxy();
      Severity: Minor
      Found in controllers/sign.js - About 1 hr to fix

        Function two_factor has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.two_factor = function (req, res, next) {
    req.checkBody({
        'name': {
            notEmpty: {
                options: [true],
        Severity: Minor
        Found in controllers/sign.js - About 1 hr to fix

          Function updatePass has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports.updatePass = function (req, res, next) {
    var psw = validator.trim(req.body.psw) || '';
    var repsw = validator.trim(req.body.repsw) || '';
    var key = validator.trim(req.body.key) || '';
    var name = validator.trim(req.body.name) || '';
          Severity: Minor
          Found in controllers/sign.js - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

                    return ep.emit('prop_err', '验证码输入不正确。');
            Severity: Major
            Found in controllers/sign.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return ep.emit('prop_err', '两次密码输入不一致。');
              Severity: Major
              Found in controllers/sign.js - About 30 mins to fix

                Function signup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                exports.signup = function (req, res, next) {
    var loginname = validator.trim(req.body.loginname).toLowerCase();
    var email = validator.trim(req.body.email).toLowerCase();
    var pass = validator.trim(req.body.pass);
    var rePass = validator.trim(req.body.re_pass);
                Severity: Minor
                Found in controllers/sign.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    req.checkBody({
        'name': {
            notEmpty: {
                options: [true],
                errorMessage: '登录名不能为空'
                Severity: Major
                Found in controllers/sign.js and 3 other locations - About 1 hr to fix
                api/v2/auth.js on lines 160..173
                api/v2/image.js on lines 313..326
                controllers/node.js on lines 6..19

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 60.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    ep.on('login_error', function (login_error) {
        res.status(403);
        res.render('sign/signin', {error: '用户名或密码错误', page: 'signin'});
    });
                Severity: Minor
                Found in controllers/sign.js and 1 other location - About 50 mins to fix
                controllers/github.js on lines 106..109

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    if (loginname.indexOf('@') !== -1) {
        getUser = User.getUserByMail;
    } else {
        getUser = User.getUserByLoginName;
    }
                Severity: Minor
                Found in controllers/sign.js and 2 other locations - About 35 mins to fix
                api/v2/auth.js on lines 90..94
                api/v2/auth.js on lines 205..209

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status