Sign upLogin

pinclub/pinclub

View on GitHub
Star
public/libs/Q.Uploader.all.js

Summary

Maintainability
F
2 mos
Test Coverage

File Q.Uploader.all.js has 854 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
* Q.js for Uploader
* author:devin87@qq.com
* update:2015/10/23 14:55
*/
Severity: Major
Found in public/libs/Q.Uploader.all.js - About 2 days to fix

    Function _init has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _init: function () {
            var self = this;

            if (self._inited) return;
            self._inited = true;
    Severity: Minor
    Found in public/libs/Q.Uploader.all.js - About 1 hr to fix

      Function draw has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              draw: function (task) {
            var self = this,
                ops = self.ops,
                boxView = ops.view;
      Severity: Minor
      Found in public/libs/Q.Uploader.all.js - About 1 hr to fix

        Function update has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                update: function (task) {
            if (!task || !task.box) return;

            var total = task.total || task.size,
                loaded = task.loaded,
        Severity: Minor
        Found in public/libs/Q.Uploader.all.js - About 1 hr to fix

          Function Uploader has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function Uploader(ops) {
        var self = this;

        //---------------- settings ----------------
          Severity: Minor
          Found in public/libs/Q.Uploader.all.js - About 1 hr to fix

            Function _upload_html5_ready has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    _upload_html5_ready: function (task) {
            var self = this;

            //上传处理
            var goto_upload = function () {
            Severity: Minor
            Found in public/libs/Q.Uploader.all.js - About 1 hr to fix

              Function queryState has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      queryState: function (task, callback) {
            var self = this,
                url = self.url,
                xhr = new XMLHttpRequest();
              Severity: Minor
              Found in public/libs/Q.Uploader.all.js - About 1 hr to fix

                Function addTask has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        addTask: function (input, file) {
            if (!input && !file) return;

            var name, size;
                Severity: Minor
                Found in public/libs/Q.Uploader.all.js - About 1 hr to fix

                  Function _upload_html5 has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          _upload_html5: function (task) {
            var self = this,
                xhr = new XMLHttpRequest();

            task.xhr = xhr;
                  Severity: Minor
                  Found in public/libs/Q.Uploader.all.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    (function (window, undefined) {
    "use strict";

    var def = Q.def,
        fire = Q.fire,
                    Severity: Major
                    Found in public/libs/Q.Uploader.all.js and 1 other location - About 1 mo to fix
                    public/libs/Q.Uploader.image.all.js on lines 378..1241

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 6105.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                    (function (window, undefined) {
    "use strict";

    var toString = Object.prototype.toString,
        has = Object.prototype.hasOwnProperty,
                    Severity: Major
                    Found in public/libs/Q.Uploader.all.js and 1 other location - About 2 wks to fix
                    public/libs/Q.Uploader.image.all.js on lines 6..370

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 2587.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    if (state == Uploader.PROCESSING) {
                    var percent = Math.min(loaded * 100 / total, 100);

                    percentText = percent.toFixed(1);
                    if (percentText == "100.0") percentText = "99.9";
                    Severity: Major
                    Found in public/libs/Q.Uploader.all.js and 1 other location - About 2 hrs to fix
                    public/libs/Q.Uploader.image.all.js on lines 1532..1540

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 94.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status