pinclub/pinclub

View on GitHub
public/libs/jquery-ujs.js

Summary

Maintainability
C
1 day
Test Coverage

File jquery-ujs.js has 278 lines of code (exceeds 250 allowed). Consider refactoring.
Open

(function ($, undefined) {

  /**
   * Unobtrusive scripting adapter for jQuery
   * https://github.com/rails/jquery-ujs
Severity: Minor
Found in public/libs/jquery-ujs.js - About 2 hrs to fix

    Function handleRemote has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        handleRemote: function (element) {
          var method, url, data, elCrossDomain, crossDomain, withCredentials, dataType, options;
    
          if (rails.fire(element, 'ajax:before')) {
            elCrossDomain = element.data('cross-domain');
    Severity: Major
    Found in public/libs/jquery-ujs.js - About 2 hrs to fix

      Avoid deeply nested control flow statements.
      Open

                if (element.data('params')) data = data + "&" + element.data('params');
      Severity: Major
      Found in public/libs/jquery-ujs.js - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $document.delegate(rails.inputChangeSelector, 'change.rails', function (e) {
              var link = $(this);
              if (!rails.allowAction(link)) return rails.stopEverything(e);
        
              rails.handleRemote(link);
        Severity: Major
        Found in public/libs/jquery-ujs.js and 1 other location - About 1 hr to fix
        public/libs/jquery-ujs.js on lines 336..342

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $document.delegate(rails.buttonClickSelector, 'click.rails', function (e) {
              var button = $(this);
              if (!rails.allowAction(button)) return rails.stopEverything(e);
        
              rails.handleRemote(button);
        Severity: Major
        Found in public/libs/jquery-ujs.js and 1 other location - About 1 hr to fix
        public/libs/jquery-ujs.js on lines 344..350

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $document.delegate(rails.formSubmitSelector, 'ajax:complete.rails', function (event) {
              if (this == event.target) rails.enableFormElements($(this));
            });
        Severity: Minor
        Found in public/libs/jquery-ujs.js and 1 other location - About 45 mins to fix
        public/libs/jquery-ujs.js on lines 407..409

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $document.delegate(rails.formSubmitSelector, 'ajax:beforeSend.rails', function (event) {
              if (this == event.target) rails.disableFormElements($(this));
            });
        Severity: Minor
        Found in public/libs/jquery-ujs.js and 1 other location - About 45 mins to fix
        public/libs/jquery-ujs.js on lines 411..413

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status