Sign upLogin

piotrmaslanka/falcon-ratelimit

View on GitHub
Star

Showing 2 of 2 total issues

Function rate_limit has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def rate_limit(per_second=30, resource=u'default', window_size=10,
Severity: Minor
Found in falconratelimit/ratelimit.py - About 35 mins to fix

    Function rate_limit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def rate_limit(per_second=30, resource=u'default', window_size=10,
               error_message="429 Too Many Requests",
               redis_url=None):
    arg = Argument(resource, window_size, per_second, error_message, redis_url)
    Severity: Minor
    Found in falconratelimit/ratelimit.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language