piotrmurach/tty-box

View on GitHub

Showing 4 of 14 total issues

Class Box has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Box
    NEWLINE = "\n"
    SPACE = " "
    LINE_BREAK = /\r\n|\r|\n/.freeze

Severity: Minor
Found in lib/tty/box.rb - About 3 hrs to fix

    Class Border has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Border
          BOX_CHARS = {
            ascii: %w[+ + + + + + + + - | +],
            light: %w[┘ ┐ ┌ └ ┤ ┴ ┬ ├ ─ │ ┼],
            thick: %w[╝ ╗ ╔ ╚ ╣ ╩ ╦ ╠ ═ ║ ╬]
    Severity: Minor
    Found in lib/tty/box/border.rb - About 2 hrs to fix

      File box.rb has 259 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require "strings"
      require "pastel"
      require "tty-cursor"
      
      require_relative "box/border"
      Severity: Minor
      Found in lib/tty/box.rb - About 2 hrs to fix

        Method render has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def render
              output = []
              output << render_top_border if @border.top?
        
              (@height - @border.top_size - @border.bottom_size).times do |y|
        Severity: Minor
        Found in lib/tty/box.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language