pivotal/LicenseFinder

View on GitHub

Showing 24 of 32 total issues

Class Decisions has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Decisions
    ######
    # READ
    ######

Severity: Minor
Found in lib/license_finder/decisions.rb - About 4 hrs to fix

    Class Configuration has 32 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Configuration
        def self.with_optional_saved_config(primary_config)
          project_path = Pathname(primary_config.fetch(:project_path, Pathname.pwd)).expand_path
          config_file =  project_path.join('config', 'license_finder.yml')
          saved_config = config_file.exist? ? YAML.safe_load(config_file.read) : {}
    Severity: Minor
    Found in lib/license_finder/configuration.rb - About 4 hrs to fix

      Class Package has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Package
          attr_reader :logger
      
          def self.license_names_from_standard_spec(spec)
            licenses = spec['licenses'] || [spec['license']].compact
      Severity: Minor
      Found in lib/license_finder/package.rb - About 2 hrs to fix

        File definitions.rb has 252 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        module LicenseFinder
          class License
            module Definitions
              extend self
        
        
        Severity: Minor
        Found in lib/license_finder/license/definitions.rb - About 2 hrs to fix

          Method prepare has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              def prepare
                if prepare_command
                  stdout, stderr, status = Dir.chdir(project_path) { Cmd.run(prepare_command) }
                  unless status.success?
                    log_errors stderr
          Severity: Minor
          Found in lib/license_finder/package_manager.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method shared_options has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def self.shared_options
                  method_option :debug,
                                aliases: '-d',
                                type: :boolean,
                                desc: 'Emit detailed info about what LicenseFinder is doing'
          Severity: Minor
          Found in lib/license_finder/cli/main.rb - About 1 hr to fix

            Method newbsd has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def newbsd
                    template = Template.named('NewBSD')
                    alternate_content = template.content.gsub(
                      'Neither the name of <organization> nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.',
                      'The names of its contributors may not be used to endorse or promote products derived from this software without specific prior written permission.'
            Severity: Minor
            Found in lib/license_finder/license/definitions.rb - About 1 hr to fix

              Method action_items has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                    def action_items
                      finder = LicenseAggregator.new(config, aggregate_paths)
                      any_packages = finder.any_packages?
                      unapproved = finder.unapproved
                      blacklisted = finder.blacklisted
              Severity: Minor
              Found in lib/license_finder/cli/main.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method longest_common_paths has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.longest_common_paths(paths)
                  [].tap do |common_paths|
                    # organize by matching root paths
                    paths_with_roots = paths.group_by { |path| path.split('/').first }
                    paths_with_roots.each do |common_root, full_paths|
              Severity: Minor
              Found in lib/license_finder/shared_helpers/common_path.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method license_finder_config has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def license_finder_config
                      extract_options(
                        :project_path,
                        :decisions_file,
                        :go_full_version,
              Severity: Minor
              Found in lib/license_finder/cli/base.rb - About 1 hr to fix

                Method packages_from_output has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    def packages_from_output(output, path)
                      package_lines = output.split("\n")
                      packages_by_sha = {}
                      package_lines.each do |p|
                        package_path, sha, repo = p.split
                Severity: Minor
                Found in lib/license_finder/package_managers/gvt.rb - About 1 hr to fix

                  Method flattened_dependencies has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def flattened_dependencies(npm_json, existing_packages = {})
                          identifier = Identifier.from_hash npm_json
                          if existing_packages[identifier].nil?
                            existing_packages[identifier] = NpmPackage.new(npm_json) if identifier
                            npm_json.fetch('dependencies', {}).values.map do |d|
                  Severity: Minor
                  Found in lib/license_finder/packages/npm_package.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method current_packages has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def current_packages
                        cmd = "#{Yarn::SHELL_COMMAND}#{production_flag}"
                        suffix = " --cwd #{project_path}" unless project_path.nil?
                        cmd += suffix unless suffix.nil?
                  
                  
                  Severity: Minor
                  Found in lib/license_finder/package_managers/yarn.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def initialize(name, version, license_text, url, options = {})
                  Severity: Minor
                  Found in lib/license_finder/packages/conan_package.rb - About 35 mins to fix

                    Method go_list has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def go_list
                          Dir.chdir(project_path) do
                            # avoid checking canonical import path. some projects uses
                            # non-canonical import path and rely on the fact that the deps are
                            # checked in. Canonical paths are only checked by `go get'. We
                    Severity: Minor
                    Found in lib/license_finder/package_managers/go_15vendorexperiment.rb - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method packages_lines has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def packages_lines(stdout)
                          packages_lines, last_package_lines =
                            stdout
                            .each_line
                            .map(&:strip)
                    Severity: Minor
                    Found in lib/license_finder/package_managers/mix.rb - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method current_packages_with_relations has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def current_packages_with_relations
                          begin
                            packages = current_packages
                          rescue StandardError => e
                            raise e unless @prepare_no_fail
                    Severity: Minor
                    Found in lib/license_finder/package_manager.rb - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method add has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def add(name, license, version = nil)
                            modifying do
                              decisions
                                .add_package(name, version, txn)
                                .license(name, license, txn)
                    Severity: Minor
                    Found in lib/license_finder/cli/dependencies.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method license_names_from_standard_spec has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def self.license_names_from_standard_spec(spec)
                          licenses = spec['licenses'] || [spec['license']].compact
                          licenses = [licenses] unless licenses.is_a?(Array)
                          licenses = licenses.flatten
                          licenses.map do |license|
                    Severity: Minor
                    Found in lib/license_finder/package.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def parse(info)
                          @lines = info.lines.map(&:chomp)
                          @state = :project_level # state of the state machine
                          @projects = [] # list of projects
                          @current_project = nil # current project being populated in the SM
                    Severity: Minor
                    Found in lib/license_finder/package_utils/conan_info_parser.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language