pivotal/LicenseFinder

View on GitHub

Showing 23 of 31 total issues

Class Decisions has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Decisions
    ######
    # READ
    ######

Severity: Minor
Found in lib/license_finder/decisions.rb - About 4 hrs to fix

    Class Configuration has 30 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Configuration
        def self.with_optional_saved_config(primary_config)
          project_path = Pathname(primary_config.fetch(:project_path, Pathname.pwd)).expand_path
          config_file =  project_path.join('config', 'license_finder.yml')
          saved_config = config_file.exist? ? YAML.safe_load(config_file.read) : {}
    Severity: Minor
    Found in lib/license_finder/configuration.rb - About 3 hrs to fix

      Class Package has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Package
          attr_reader :logger
      
          def self.license_names_from_standard_spec(spec)
            licenses = spec['licenses'] || [spec['license']].compact
      Severity: Minor
      Found in lib/license_finder/package.rb - About 2 hrs to fix

        Method prepare has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            def prepare
              if self.class.prepare_command
                stdout, stderr, status = Dir.chdir(project_path) { Cmd.run(self.class.prepare_command) }
                unless status.success?
                  log_errors stderr
        Severity: Minor
        Found in lib/license_finder/package_manager.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method shared_options has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def self.shared_options
                method_option :debug,
                              aliases: '-d',
                              type: :boolean,
                              desc: 'Emit detailed info about what LicenseFinder is doing'
        Severity: Minor
        Found in lib/license_finder/cli/main.rb - About 1 hr to fix

          Method longest_common_paths has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.longest_common_paths(paths)
              [].tap do |common_paths|
                # organize by matching root paths
                paths_with_roots = paths.group_by { |path| path.split('/').first }
                paths_with_roots.each do |common_root, full_paths|
          Severity: Minor
          Found in lib/license_finder/shared_helpers/common_path.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method action_items has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

                def action_items
                  finder = LicenseAggregator.new(config, aggregate_paths)
                  any_packages = finder.any_packages?
                  unapproved = finder.unapproved
                  blacklisted = finder.blacklisted
          Severity: Minor
          Found in lib/license_finder/cli/main.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method newbsd has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def newbsd
                  template = Template.named('NewBSD')
                  alternate_content = template.content.gsub(
                    'Neither the name of <organization> nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.',
                    'The names of its contributors may not be used to endorse or promote products derived from this software without specific prior written permission.'
          Severity: Minor
          Found in lib/license_finder/license/definitions.rb - About 1 hr to fix

            Method packages_from_output has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def packages_from_output(output, path)
                  package_lines = output.split("\n")
                  packages_by_sha = {}
                  package_lines.each do |p|
                    package_path, sha, repo = p.split
            Severity: Minor
            Found in lib/license_finder/package_managers/gvt.rb - About 1 hr to fix

              Method flattened_dependencies has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                    def flattened_dependencies(npm_json, existing_packages = {})
                      identifier = Identifier.from_hash npm_json
                      if existing_packages[identifier].nil?
                        existing_packages[identifier] = NpmPackage.new(npm_json) if identifier
                        npm_json.fetch('dependencies', {}).values.map do |d|
              Severity: Minor
              Found in lib/license_finder/packages/npm_package.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method current_packages has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  def current_packages
                    cmd = "#{Yarn::SHELL_COMMAND}#{production_flag}"
                    suffix = " --cwd #{project_path}" unless project_path.nil?
                    cmd += suffix unless suffix.nil?
              
              
              Severity: Minor
              Found in lib/license_finder/package_managers/yarn.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method aggregate_paths has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                    def aggregate_paths
                      check_valid_project_path
                      aggregate_paths = config.aggregate_paths
                      project_path = config.project_path || Pathname.pwd
                      aggregate_paths = ProjectFinder.new(project_path, config.strict_matching).find_projects if config.recursive
              Severity: Minor
              Found in lib/license_finder/cli/main.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def initialize(name, version, license_text, url, options = {})
              Severity: Minor
              Found in lib/license_finder/packages/conan_package.rb - About 35 mins to fix

                Method go_list has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def go_list
                      Dir.chdir(project_path) do
                        # avoid checking canonical import path. some projects uses
                        # non-canonical import path and rely on the fact that the deps are
                        # checked in. Canonical paths are only checked by `go get'. We
                Severity: Minor
                Found in lib/license_finder/package_managers/go_15vendorexperiment.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method current_packages_with_relations has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def current_packages_with_relations
                      begin
                        packages = current_packages
                      rescue StandardError => e
                        raise e unless @prepare_no_fail
                Severity: Minor
                Found in lib/license_finder/package_manager.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method packages_lines has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def packages_lines(stdout)
                      packages_lines, last_package_lines =
                        stdout
                        .each_line
                        .map(&:strip)
                Severity: Minor
                Found in lib/license_finder/package_managers/mix.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method add has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                      def add(name, license, version = nil)
                        modifying do
                          decisions
                            .add_package(name, version, txn)
                            .license(name, license, txn)
                Severity: Minor
                Found in lib/license_finder/cli/dependencies.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method current_packages has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def current_packages
                      command = "#{package_management_command} org.codehaus.mojo:license-maven-plugin:download-licenses"
                      command += " -Dlicense.excludedScopes=#{@ignored_groups.to_a.join(',')}" if @ignored_groups && !@ignored_groups.empty?
                      command += " #{@maven_options}" unless @maven_options.nil?
                      _stdout, stderr, status = Dir.chdir(project_path) { Cmd.run(command) }
                Severity: Minor
                Found in lib/license_finder/package_managers/maven.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method approval_of has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def approval_of(name, version = nil)
                      if !@approvals.key?(name)
                        nil
                      elsif !version.nil?
                        @approvals[name] if @approvals[name][:safe_versions].empty? || @approvals[name][:safe_versions].include?(version)
                Severity: Minor
                Found in lib/license_finder/decisions.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method say_each has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                      def say_each(coll)
                        if coll.any?
                          coll.each do |item|
                            say(block_given? ? yield(item) : item)
                          end
                Severity: Minor
                Found in lib/license_finder/cli/base.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language