Sign upLogin

pivotal/pivotal_ide_prefs

View on GitHub
Star

Showing 2 of 6 total issues

Method assert_works_like_user_prefs_repo has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def assert_works_like_user_prefs_repo(pref_factory: nil, user_prefs_repo_factory: nil)
  describe "User Prefs Repo" do

    assert_works_like_basic_prefs_repo(pref_factory: pref_factory, prefs_repo_factory: user_prefs_repo_factory)
Severity: Major
Found in ide_prefs/lib/ide_prefs_test_support/contracts/user_prefs_repo_contract.rb - About 2 hrs to fix

    Method start has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def start
    @logs.each do |log|
      log = log.new

      logger = @logger
    Severity: Minor
    Found in logging/lib/logging.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language