plainblack/Lacuna-Web-Client

File archaeology.js has 586 lines of code (exceeds 250 allowed). Consider refactoring.

Open

YAHOO.namespace("lacuna.buildings");

if (typeof YAHOO.lacuna.buildings.Archaeology == "undefined" || !YAHOO.lacuna.buildings.Archaeology) {

(function(){

Function ArchaeologyExcavators has 73 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    ArchaeologyExcavators : function() {
      var excavators = this.excavators.excavators,
                       details = Dom.get("excavatorDetails");
        
      if(details) {

Function populateView has 56 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    populateView : function() {
      var glyphs = this.glyphs,
        details = Dom.get("archaeologyGlyphDetails");
        
      if(details) {

Function onDragDrop has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    onDragDrop: function(e, id) {
      if (id == "archaeologyGlyphDetails") {

        // The position of the cursor at the time of the drop (YAHOO.util.Point)
        var pt = DDM.interactionInfo.point; 

Function _getViewTab has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _getViewTab : function() {
      var tab = new YAHOO.widget.Tab({ label: "View Glyphs", content: [
        '<div class="clearafter">',
        '  <div class="archaeologySlots">',
        '    <label>Available Glyphs</label>',

Function _getSearchTab has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _getSearchTab : function() {
      var tab = new YAHOO.widget.Tab({ label: "Search", content: [
        '<div id="archaeologySearchContainer">',
        '  <ul id="archaeologySearchForm">',
        '    <li>Search Ore:<select id="archaeologyOre"></select></li>',

Function populateSearch has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    populateSearch : function() {
      var sel = Dom.get("archaeologyOre");
      if(sel && this.ore){
        sel.options.length = 0;
        var opt = document.createElement("option"),

Avoid deeply nested control flow statements.

Open

          if (fromAvailableList) {
            // moving from 'details' list to 'combine' list
            // clone it - don't just move it
            var clone = El.cloneNode(true);
            this._removeGlyphCount(clone);

Avoid deeply nested control flow statements.

Open

            if(total > 0) {
              outChance.splice(5, 0, '<li><label>Total:</label> ');
              outChance.splice(6, 0, parseInt(total));
              outChance.splice(7, 0, '</li>');
            }

Avoid deeply nested control flow statements.

Open

            if (obj.id > 0) {
              nLi = li.cloneNode(false);
              Dom.addClass(nLi,"excavatorAbandon");
              var bbtn = document.createElement("button");
              bbtn.setAttribute("type", "button");

Avoid deeply nested control flow statements.

Open

            for (var chance_i in ctypes) {
              var chance = ctypes[chance_i];
              if(obj[chance] > 0) {
                outChance.push('<li><label>' + chance.replace(/^\w/,
                               function(c){ return c.toUpperCase() }) +

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      if(confirm(["Are you sure you want to Abandon the excavator ",this.Excavator.id," at  ",this.Excavator.body.name,"?"].join(''))) {
        require('js/actions/menu/loader').show();
        
        this.Self.service.abandon_excavator({
          session_id:Game.GetSession(),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    getGlyphs : function() {
      if(!this.glyphs) {
        require('js/actions/menu/loader').show();
        this.service.get_glyphs({session_id:Game.GetSession(),building_id:this.building.id}, {
          success : function(o){

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    getOres : function() {
      if(!this.ore) {
        require('js/actions/menu/loader').show();
        this.service.get_ores_available_for_processing({session_id:Game.GetSession(),building_id:this.building.id}, {
          success : function(o){

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    AbandonAllExcavators : function(e) {
        if(confirm("Are you sure you want to abandon all excavators controlled by this Archaeology Ministry?")) {
            require('js/actions/menu/loader').show();
            this.service.mass_abandon_excavator({
                    session_id:Game.GetSession(),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(!this.glyphCombine) {
          this.glyphCombine = new Util.DDTarget("archaeologyGlyphCombine");
          this.glyphCombine.isGlyphContainer = true;
        }
        else {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(!this.glyphList) {
          this.glyphList = new Util.DDTarget("archaeologyGlyphDetails");
          this.glyphList.isGlyphContainer = true;
        }
        else {

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    searchQueue : function(remaining, el){
      if(remaining <= 0) {
        var span = Dom.get(el),
          p = span.parentNode;
        p.removeChild(span);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _getExcavatorTab : function() {
      this.excavatorTab = new YAHOO.widget.Tab({ label: "Excavators", content: [
        '<div id="excavatorInfo"></div>',
        '<div class="excavatorContainer">',
        '  <div id="excavatorDetails">',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  var Lang = YAHOO.lang,
    Util = YAHOO.util,
    DDM = Util.DragDropMgr,
    Dom = Util.Dom,
    Event = Util.Event,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    viewAdd : function(e, matchedEl, container) { 
      matchedEl.parentNode.removeChild(matchedEl);
      Dom.get("archaeologyGlyphCombine").appendChild(matchedEl);
    },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    viewRemove : function(e, matchedEl, container) { 
      matchedEl.parentNode.removeChild(matchedEl);
      Dom.get("archaeologyGlyphDetails").appendChild(matchedEl);
    },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            nLi.innerHTML = ['<img src="',Lib.AssetUrl,'star_system/',obj.body.image,'.png" />', obj.body.name].join('');

• Read up
  Read up