plainblack/Lacuna-Web-Client

File embassy.js has 1126 lines of code (exceeds 250 allowed). Consider refactoring.

Open

YAHOO.namespace("lacuna.buildings");

if (typeof YAHOO.lacuna.buildings.Embassy == "undefined" || !YAHOO.lacuna.buildings.Embassy) {
    
(function(){

Function StashSubmit has 75 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        StashSubmit : function() {
            var data = {
                    session_id: Game.GetSession(""),
                    building_id: this.building.id
                },

Function StashPopulate has 65 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        StashPopulate : function() {
            /*        
            "stash" : {"gold" : 4500},
            "stored" : {"energy" : 40000},
            "max_exchange_size" : 30000,

Function MembersPopulate has 47 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        MembersPopulate : function() {
            var details = Dom.get("embassyMemberDetails");
            if(details && this.alliance) {
                var members = this.alliance.members,
                    ul = document.createElement("ul"),

Function InvitesPopulate has 47 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        InvitesPopulate : function() {
            var details = Dom.get("embassyInvitesDetails");
            if(details) {
                var invites = this.invites,
                    ul = document.createElement("ul"),

Function StashDonateAdd has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        StashDonateAdd : function(e, matchedEl, container){
            var quantity = Lib.getSelectedOptionValue(matchedEl.previousSibling)*1,
                li = matchedEl.parentNode,
                c = Dom.get("embassyStashToDonate");
            if(quantity && c) {

Function StashExchangeAdd has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        StashExchangeAdd : function(e, matchedEl, container){
            var quantity = Lib.getSelectedOptionValue(matchedEl.previousSibling)*1,
                li = matchedEl.parentNode,
                c = Dom.get("embassyStashToExchange");
            if(quantity && c) {

Function PendingPopulate has 39 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        PendingPopulate : function() {
            var details = Dom.get("embassySendDetails");
            if(details) {
                var pendingInvites = this.pendingInvites,
                    ul = document.createElement("ul"),

Function _getStashTab has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _getStashTab : function() {
            this.stashTab = new YAHOO.widget.Tab({ label: "Stash", content: [
            '<div id="embassyStashAnnounce"></div>',
            '<div class="embassyStash yui-g">',
            '    <div class="yui-g first">',

Function PropLineDetails has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        PropLineDetails : function(prop, sec) {
            if(prop.status == "Passed" || prop.status == "Failed") {
                return ['<div style="margin-bottom:2px;">',
                    '<div class="yui-gb">',
                    '    <div class="yui-u first"><label>',prop.name,'</label></div>',

Function _getAllianceTab has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _getAllianceTab : function() {
            var div = document.createElement("div");
            if(this.isLeader) {
                div.innerHTML = ['<div>',
                '    <ul>',

Function _createSendToSelect has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _createSendToSelect : function() {
            var dataSource = new Util.XHRDataSource("/empire");
            dataSource.connMethodPost = "POST";
            dataSource.maxCacheEntries = 2;
            dataSource.responseType = YAHOO.util.XHRDataSource.TYPE_JSON;

Function InvitesAccept has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        InvitesAccept : function() {
            if(confirm(['Are you sure you want to accept the alliance invite from ', this.Invite.name,'?'].join(''))) {
                this.Self.service.accept_invite({
                    session_id:Game.GetSession(""),
                    building_id:this.Self.building.id,

Function _getPropsTab has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _getPropsTab : function() {
            var tab = new YAHOO.widget.Tab({ label: "Propositions", content: [
                '<div>',
                '    <div style="overflow:auto;"><ul id="propsDetails"></ul></div>',
                '</div>'

Function CreateAlliance has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        CreateAlliance : function() {
            var data = {
                session_id: Game.GetSession(""),
                building_id: this.building.id,
                name: Dom.get("embassyCreateName").value

Function PropsPopulate has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        PropsPopulate : function() {
            var details = Dom.get("propsDetails");
            
            if(details) {
                var props = this.props,

Avoid deeply nested control flow statements.

Open

                        if(Lang.isArray(resource)) {
                            for(x=0; x < resource.length; x++) {
                                name = resource[x];
                                if(stash.stored[name]) {
                                    nLi = li.cloneNode(false);

Avoid deeply nested control flow statements.

Open

                        if(Lang.isArray(resource)) {
                            for(x=0; x < resource.length; x++) {
                                name = resource[x];
                                if(stash.stash[name]) {
                                    nLi = li.cloneNode(false);

Consider simplifying this complex logical expression.

Open

if (typeof YAHOO.lacuna.buildings.Embassy == "undefined" || !YAHOO.lacuna.buildings.Embassy) {
    
(function(){
    var Lang = YAHOO.lang,
        Util = YAHOO.util,

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        StashDonateAdd : function(e, matchedEl, container){
            var quantity = Lib.getSelectedOptionValue(matchedEl.previousSibling)*1,
                li = matchedEl.parentNode,
                c = Dom.get("embassyStashToDonate");
            if(quantity && c) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        StashExchangeAdd : function(e, matchedEl, container){
            var quantity = Lib.getSelectedOptionValue(matchedEl.previousSibling)*1,
                li = matchedEl.parentNode,
                c = Dom.get("embassyStashToExchange");
            if(quantity && c) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        PropsPopulate : function() {
            var details = Dom.get("propsDetails");
            
            if(details) {
                var props = this.props,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(inStash && stash.stash) {
                inStash.innerHTML = "";                
                for(r in Lib.ResourceTypes) {
                    if(Lib.ResourceTypes.hasOwnProperty(r)) {
                        resource = Lib.ResourceTypes[r];

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(onPlanet) {
                onPlanet.innerHTML = "";
                
                for(r in Lib.ResourceTypes) {
                    if(Lib.ResourceTypes.hasOwnProperty(r)) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        _getPropsTab : function() {
            var tab = new YAHOO.widget.Tab({ label: "Propositions", content: [
                '<div>',
                '    <div style="overflow:auto;"><ul id="propsDetails"></ul></div>',
                '</div>'

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        formatBody : function(body) {
            body = body.replace(/&/g,'&');
            body = body.replace(/</g,'&lt;');
            body = body.replace(/>/g,'&gt;');
            body = body.replace(/\n/g,'<br />');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(confirm(['Are you sure you want to reject the alliance invite from ', this.Invite.name,'?'].join(''))) {                
                this.Self.service.reject_invite({
                    session_id:Game.GetSession(""),
                    building_id:this.Self.building.id,
                    invite_id:this.Invite.id,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(confirm(['Are you sure you want to withdraw the invite from ', this.Invite.name].join(''))) {
                this.Self.service.withdraw_invite({
                    session_id:Game.GetSession(""),
                    building_id:this.Self.building.id,
                    invite_id:this.Invite.id,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        PropLineDetails : function(prop, sec) {
            if(prop.status == "Passed" || prop.status == "Failed") {
                return ['<div style="margin-bottom:2px;">',
                    '<div class="yui-gb">',
                    '    <div class="yui-u first"><label>',prop.name,'</label></div>',

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        PropVoteSuccess  : function(o){
            this.Self.rpcSuccess(o);
            var newProp = o.result.proposition;
            for(var i=0; i<this.Self.props.length; i++) {
                if(this.Self.props[i].id == newProp.id) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                }, {
                    success : function(o){
                        YAHOO.log(o, "info", "Embassy.leave_alliance.success");
                        this.rpcSuccess(o);
                        delete this.alliance;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                }, {
                    success : function(o){
                        YAHOO.log(o, "info", "Embassy.dissolve_alliance.success");
                        this.rpcSuccess(o);
                        delete this.alliance;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        PropQueue : function(remaining, elLine){
            var arrTime;
            if(remaining <= 0) {
                arrTime = 'Overdue ' + Lib.formatTime(Math.round(-remaining));
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if(newTotal == 0) {
                    this.updateStashDonate(li.Object.quantity * -1);
                    Event.purgeElement(li);
                    li.parentNode.removeChild(li);
                }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if(newTotal == 0) {
                    this.updateStashExchange(li.Object.quantity * -1);
                    Event.purgeElement(li);
                    li.parentNode.removeChild(li);
                }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        PropClick : function(e, matchedEl, container){
            var type = matchedEl.innerHTML;
            if(type == "Yes" || type == "No") {
                var el = Dom.getAncestorByTagName(matchedEl, "li"),
                    func = this["PropVote"+type];

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        handlePlanetLink : function(e, el) {
            Event.stopEvent(e);
            var res = el.href.match(/\#(-?\d+)$/);
            this.hide();
            var planet = Game.EmpireData.planets[res[1]];

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        PropVoteNo : function(prop, line) {
            this.service.cast_vote({
                session_id:Game.GetSession(""),
                building_id:this.building.id,
                proposition_id:prop.id,

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        PropVoteYes : function(prop, line) {
            this.service.cast_vote({
                session_id:Game.GetSession(""),
                building_id:this.building.id,
                proposition_id:prop.id,

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

            oTextboxList.generateRequest = function(sQuery){                
                var s = Lang.JSON.stringify({
                        "id": YAHOO.rpc.Service._requestId++,
                        "method": "find",
                        "jsonrpc": "2.0",

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        for(n=0; n<toExchangeLis.length; n++) {
                            if(toExchangeLis[n].Object) {
                                Event.purgeElement(toExchangeLis[n]);
                                toExchangeLis[n].parentNode.removeChild(toExchangeLis[n]);
                            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        for(n=0; n<toDonateLis.length; n++) {
                            if(toDonateLis[n].Object) {
                                Event.purgeElement(toDonateLis[n]);
                                toDonateLis[n].parentNode.removeChild(toDonateLis[n]);
                            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            for(n=0; n<toExchangeLis.length; n++) {
                obj = toExchangeLis[n].Object;
                if(obj) {
                    exchangeItems[obj.type] = obj.quantity;
                    exchangeTotal += obj.quantity;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            for(n=0; n<toDonateLis.length; n++) {
                obj = toDonateLis[n].Object;
                if(obj) {
                    donateItems[obj.type] = obj.quantity;
                    donateTotal += obj.quantity;

• Read up
  Read up

Identical blocks of code found in 4 locations. Consider refactoring.

Open

        handleStarmapLink : function(e, el) {
            Event.stopEvent(e);
            var res = el.href.match(/\#(-?\d+)x(-?\d+)$/);
            Game.StarJump({x:res[1],y:res[2]});
        },

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

        handleProfileLink : function(e, el) {
            Event.stopEvent(e);
            var res = el.href.match(/\#(-?\d+)$/);
            if(res) {
                Lacuna.Info.Empire.Load(res[1]);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            this.stashTab = new YAHOO.widget.Tab({ label: "Stash", content: [
            '<div id="embassyStashAnnounce"></div>',
            '<div class="embassyStash yui-g">',
            '    <div class="yui-g first">',
            '        <div class="yui-u first">',

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        handleAllianceLink : function(e, el) {
            Event.stopEvent(e);
            var res = el.href.match(/\#(-?\d+)$/);
            Lacuna.Info.Alliance.Load(res[1]);
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        PropVoteDetails : function(prop) {
            if(prop.my_vote !== undefined) {
                return '<label>Voted ' + (prop.my_vote*1 === 1 ? 'Yes' : 'No') + '</label>';
            }
            else {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

            var oTextboxList = new YAHOO.lacuna.TextboxList("embassySendTo", dataSource, { //config options
                maxResultsDisplayed: 10,
                minQueryLength:3,
                multiSelect:false,
                forceSelection:true,

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        updateStashDonate : function(byVal) {
            var c = Dom.get("embassyTotalDonate"),
                cv = c.innerHTML*1;
            c.innerHTML = cv + byVal;
        },

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        updateStashExchange : function(byVal) {
            var c = Dom.get("embassyTotalExchange"),
                cv = c.innerHTML*1;
            c.innerHTML = cv + byVal;
        },

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                        this.Self.isLeader = this.Self.alliance && this.Self.alliance.leader_id == Game.EmpireData.id;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            this.memberTab = new YAHOO.widget.Tab({ label: "Members", content: ['<div>',
            '    <ul class="embassyHeader embassyInfo clearafter">',
            '        <li class="embassyEmpire">Empire</li>',
            '        <li class="embassyAction"></li>',
            '        <li class="embassyMessage"></li>',

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                        this.Self.isLeader = this.Self.alliance && this.Self.alliance.leader_id == Game.EmpireData.id;

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                this.service.leave_alliance({
                    session_id:Game.GetSession(""),
                    building_id:this.building.id,
                    message:Dom.get("embassyAllianceLeaveReason").value
                }, {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            var data = {
                session_id: Game.GetSession(""),
                building_id: this.building.id,
                name: Dom.get("embassyCreateName").value
            };

• Read up
  Read up