Sign upLogin

plainblack/Lacuna-Web-Client

View on GitHub
Star
app/js-yui/building/geneticsLab.js

Summary

Maintainability
D
1 day
Test Coverage

File geneticsLab.js has 337 lines of code (exceeds 250 allowed). Consider refactoring.
Open

YAHOO.namespace("lacuna.buildings");

if (typeof YAHOO.lacuna.buildings.GeneticsLab == "undefined" || !YAHOO.lacuna.buildings.GeneticsLab) {
    
(function(){
Severity: Minor
Found in app/js-yui/building/geneticsLab.js - About 4 hrs to fix

    Function getSpeciesStatList has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            getSpeciesStatList : function(stat) {
            var frag = document.createDocumentFragment(),
                li = document.createElement('li');
            
            var nLi = li.cloneNode(false);
    Severity: Major
    Found in app/js-yui/building/geneticsLab.js - About 3 hrs to fix

      Function updateDisplay has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              updateDisplay : function(exp) {
            Dom.get("geneticsLabSurvival").innerHTML = exp.survival_odds;
            Dom.get("geneticsLabGraft").innerHTML = exp.graft_odds;
            Dom.get("geneticsLabCost").innerHTML = exp.essentia_cost;
            Dom.removeClass(Sel.query("li.selected", "geneticsLabSpies"),"selected");
      Severity: Minor
      Found in app/js-yui/building/geneticsLab.js - About 1 hr to fix

        Function _getLabTab has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                _getLabTab : function() {
            this.tab = new YAHOO.widget.Tab({ label: "Lab", content: [
                '<table class="tleTable">',
                '    <tr>',
                '        <th>Survival Chance</th><th>Graft Success</th><th>Essentia Cost</th>',
        Severity: Minor
        Found in app/js-yui/building/geneticsLab.js - About 1 hr to fix

          Function RenameSpecies has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  RenameSpecies : function(e) {
            Event.stopEvent(e);
            var btn = Event.getTarget(e);
            var newName = Dom.get('newSpeciesName').value;
            var newDesc = Dom.get('newSpeciesDesc').value.substr(0,1024);
          Severity: Minor
          Found in app/js-yui/building/geneticsLab.js - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

                                    return 0;
            Severity: Major
            Found in app/js-yui/building/geneticsLab.js - About 30 mins to fix

              Similar blocks of code found in 17 locations. Consider refactoring.
              Open

                  var Lang = YAHOO.lang,
        Util = YAHOO.util,
        Dom = Util.Dom,
        Event = Util.Event,
        Sel = Util.Selector,
              Severity: Major
              Found in app/js-yui/building/geneticsLab.js and 16 other locations - About 1 hr to fix
              app/js-yui/building.js on lines 8..15
              app/js-yui/building/development.js on lines 6..13
              app/js-yui/building/distributionCenter.js on lines 6..13
              app/js-yui/building/missionCommand.js on lines 6..13
              app/js-yui/building/network19.js on lines 6..13
              app/js-yui/building/park.js on lines 6..13
              app/js-yui/building/planetaryCommand.js on lines 13..20
              app/js-yui/building/shipyard.js on lines 6..13
              app/js-yui/building/spaceStationLab.js on lines 6..13
              app/js-yui/login.js on lines 13..20
              app/js-yui/mapPlanet.js on lines 12..19
              app/js-yui/mapStar.js on lines 8..15
              app/js-yui/module/parliament.js on lines 6..13
              app/js-yui/module/stationCommand.js on lines 6..13
              app/js-yui/profile.js on lines 13..20
              app/js-yui/stats.js on lines 12..19

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          nLi.innerHTML = [
                '<label>Habitable Orbits</label>',
                '<span>', stat.min_orbit,
                stat.max_orbit > stat.min_orbit ? ' to '+ stat.max_orbit : '',
                '</span>'
              Severity: Major
              Found in app/js-yui/building/geneticsLab.js and 1 other location - About 1 hr to fix
              app/js-yui/profile.js on lines 566..571

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status