plainblack/Lacuna-Web-Client

File intelligence.js has 550 lines of code (exceeds 250 allowed). Consider refactoring.

Open

YAHOO.namespace("lacuna.buildings");

if (typeof YAHOO.lacuna.buildings.Intelligence == "undefined" || !YAHOO.lacuna.buildings.Intelligence) {
    
(function(){

Function SpyInfo has 145 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        SpyInfo : function(spy) {
            var assign = spy.possible_assignments,
                div = document.createElement("div"),
                ul = document.createElement("ul"),
                li = document.createElement("li"),

Function SpyAssign has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        SpyAssign : function() {
            require('js/actions/menu/loader').show();
            var assign = this.Assign[this.Assign.selectedIndex].value;
            
            this.Self.service.assign_spy({

Function SpyPopulate has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        SpyPopulate : function() {
            var details = Dom.get("spiesDetails");
            if(details) {
                var spies = this.spies.spies,
                    nDiv,

Function _getTrainTab has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _getTrainTab : function() {
            var spies = this.result.spies;
            this.trainTab = new YAHOO.widget.Tab({ label: "Train Spies", content: [
                '<div class="yui-g">',
                '    <div class="yui-u first">',

Function spiesView has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        spiesView : function(e) {
            if(e.newValue) {
                if(!this.spies) {
                    require('js/actions/menu/loader').show();
                    this.service.view_spies({session_id:Game.GetSession(),building_id:this.building.id}, {

Function SpyNameSave has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        SpyNameSave : function(e) {
            Event.stopEvent(e);
            require('js/actions/menu/loader').show();
            var newName = this.Input.value;
            

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        SpyName : function() {
            this.el.innerHTML = "";
            
            var inp = document.createElement("input"),
                bSave = document.createElement("button"),

• Read up
  Read up

Identical blocks of code found in 7 locations. Consider refactoring.

Open

    var Lang = YAHOO.lang,
        Util = YAHOO.util,
        Dom = Util.Dom,
        Event = Util.Event,
        Pager = YAHOO.widget.Paginator,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            }, {
                success : function(o){
                    YAHOO.log(o, "info", "Intelligence.SpyHandlePagination.view_spies.success");
                    require('js/actions/menu/loader').hide();
                    this.rpcSuccess(o);

• Read up
  Read up

Identical blocks of code found in 4 locations. Consider refactoring.

Open

        handleStarmapLink : function(e, el) {
            Event.stopEvent(e);
            var res = el.href.match(/\#(-?\d+)x(-?\d+)$/);
            Game.StarJump({x:res[1],y:res[2]});
        },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        destroy : function() {
            if(this.pager) {
                this.pager.destroy();
            }
            Intelligence.superclass.destroy.call(this);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            nLi.innerHTML = '<label>Assigned To:</label> <a class="starmap_link" href="#' + spy.assigned_to.x + 'x' + spy.assigned_to.y + '">' + spy.assigned_to.name + '</a>';

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            this.Self.service.name_spy({
                session_id:Game.GetSession(),
                building_id:this.Self.building.id,
                spy_id:this.Spy.id,
                name:newName

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            this.renameTab = new YAHOO.widget.Tab({ label: "Rename All", content: [
                '<div>',
                '  <p>Prefix: <input id="spiesRenamePrefix" type="text" /> Suffix: <input id="spiesRenameSuffix" type="text" /> Rename Agent Null only: <input id="spiesNullOnly" type="checkbox" /> <button id="spiesRename" type="button">Rename All</button></p>',
                '  <p>This will rename all spies managed by this planet at once to have the prefix and/or suffix you specify. A two-digit number, from 01 to the number of spies you have, will be placed after the prefix / before the suffix.</p>',
                '  <p>If you specify Agent Null only, then only those spies will be renamed, even if the name does not otherwise fit your prefix and suffix, otherwise all spies will be normalised to this naming scheme.</p>',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                failure : function(o){
                    if(this.Input) {
                        this.Input.value = this.Spy.name;
                    }
                },

• Read up
  Read up