plainblack/Lacuna-Web-Client

File mercenariesGuild.js has 464 lines of code (exceeds 250 allowed). Consider refactoring.

Open

YAHOO.namespace("lacuna.buildings");

if (typeof YAHOO.lacuna.buildings.MercenariesGuild == "undefined" || !YAHOO.lacuna.buildings.MercenariesGuild) {
    
(function(){

Function AvailablePopulate has 59 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        AvailablePopulate : function() {
            var details = Dom.get("tradeAvailableDetails");
            
            if(details) {
                var trades = this.availableMercs.trades,

Function MinePopulate has 44 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        MinePopulate : function() {
            var details = Dom.get("tradeMineDetails");
            
            if(details) {
                var trades = this.mineMercs.trades,

Function AddMerc has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        AddMerc : function(e) {
            var qVal = Dom.get("tradeAddAskingQuantity").value*1;
            if(!Lang.isNumber(qVal) || qVal <= 0) {
                Dom.get("tradeAddMessage").innerHTML = "Quantity of asking essentia must be a number and greater than 0";
                return;

Function MineWithdraw has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        MineWithdraw : function(e) {
            var btn = Event.getTarget(e);
            btn.disabled = true;
            if(confirm(['Are you sure you want to withdraw the trade asking for ', this.Trade.ask, ' essentia and offering ', this.Trade.offer,'?'].join(''))) {
                require('js/actions/menu/loader').show();

Function getAddShips has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        getAddShips : function(e) {
            if(e.newValue && !this.tradeShips) {
                require('js/actions/menu/loader').show();
                
                this.service.get_trade_ships({

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        MinePopulate : function() {
            var details = Dom.get("tradeMineDetails");
            
            if(details) {
                var trades = this.mineMercs.trades,

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        MineHandlePagination : function(newState) {
            require('js/actions/menu/loader').show();
            this.service.view_my_market({
                session_id:Game.GetSession(),
                building_id:this.building.id,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                this.service.view_my_market({session_id:Game.GetSession(),building_id:this.building.id,page_number:1}, {
                    success : function(o){
                        require('js/actions/menu/loader').hide();
                        this.rpcSuccess(o);
                        

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                this.service.view_market(data, {
                    success : function(o){
                        require('js/actions/menu/loader').hide();
                        this.rpcSuccess(o);
                        

• Read up
  Read up

Identical blocks of code found in 5 locations. Consider refactoring.

Open

    var Lang = YAHOO.lang,
        Util = YAHOO.util,
        Dom = Util.Dom,
        Event = Util.Event,
        Sel = Util.Selector,

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        destroy : function() {
            if(this.availablePager) {
                this.availablePager.destroy();
            }
            if(this.minePage) {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        _getMineTab : function() {
            this.mine = new YAHOO.widget.Tab({ label: "My Mercs", content: ['<div class="myMercenariesGuilds">',
                '    <ul class="tradeHeader tradeInfo clearafter">',
                '        <li class="tradeOfferedDate">Offered Date</li>',
                '        <li class="tradeAsking">Cost</li>',

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

            if(!Lang.isNumber(qVal) || qVal <= 0) {
                Dom.get("tradeAddMessage").innerHTML = "Quantity of asking essentia must be a number and greater than 0";
                return;
            }
            else {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        updateAddCargo : function(byVal) {
            var c = Dom.get("tradeAddCargo"),
                cv = c.innerHTML*1;
            c.innerHTML = cv + byVal;
        },

• Read up
  Read up