plainblack/Lacuna-Web-Client

File miningMinistry.js has 363 lines of code (exceeds 250 allowed). Consider refactoring.

Open

YAHOO.namespace("lacuna.buildings");

if (typeof YAHOO.lacuna.buildings.MiningMinistry == "undefined" || !YAHOO.lacuna.buildings.MiningMinistry) {
    
(function(){

Function MiningMinistryPlatforms has 95 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        MiningMinistryPlatforms : function() {
            var platforms = this.platforms.platforms,
                details = Dom.get("platformDetails");
                
            if(details) {

Function MiningMinistryShipsPopulate has 60 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        MiningMinistryShipsPopulate : function() {
            var ships = this.ships,
                details = Dom.get("shipsDetails");
            
            if(details) {

Avoid deeply nested control flow statements.

Open

                        if(totals[ore_i] > 0) {
                            outOre.push('<li><label>' + ore.replace(/^\w/, function(c){ return c.toUpperCase() }) + ':</label> ');
                            outOre.push(totals[ore_i]);
                            outOre.push('</li>');
                        }

Avoid deeply nested control flow statements.

Open

                        for (var ore_i in ores) {
                            var ore = ores[ore_i];
                            if(obj[ore + '_hour'] > 0) {
                                outOre.push('<li><label>' + ore.replace(/^\w/, function(c){ return c.toUpperCase() }) + ':</label> ');
                                outOre.push(obj[ore+'_hour']);

Avoid deeply nested control flow statements.

Open

                        if(total > 0) {
                            outOre.splice(1, 0, '<li><label>Total:</label> ');
                            outOre.splice(2, 0, parseInt(total));
                            outOre.splice(3, 0, '</li>');
                            grand_total += total;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(confirm(["Are you sure you want to Abandon the mining platform at  ",this.Platform.asteroid.name,"?"].join(''))) {
                require('js/actions/menu/loader').show();
                
                this.Self.service.abandon_platform({
                    session_id:Game.GetSession(),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        MiningMinistryShipsAdd : function() {
            require('js/actions/menu/loader').show();
                
            this.Self.service.add_cargo_ship_to_fleet({
                session_id:Game.GetSession(),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        MiningMinistryShipsRemove : function() {
            require('js/actions/menu/loader').show();
            
            this.Self.service.remove_cargo_ship_from_fleet({
                session_id:Game.GetSession(),

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        AbandonAllPlatforms : function(e) {
            if(confirm("Are you sure you want to abandon all platforms controlled by this Mining Ministry?")) {
                require('js/actions/menu/loader').show();
                this.service.mass_abandon_platform({
                        session_id:Game.GetSession(),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        MiningMinistryShipsView : function() {
            require('js/actions/menu/loader').show();
            this.service.view_ships({session_id:Game.GetSession(),building_id:this.building.id}, {
                success : function(o){
                    YAHOO.log(o, "info", "MiningMinistry.MiningMinistryShipsView.success");

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        _getShipsTab : function() {
            this.shipsTab = new YAHOO.widget.Tab({ label: "Ships", content: [
                '<div class="shipsContainer">',
                '    <ul class="shipHeader shipInfo clearafter">',
                '        <li class="shipName">Name</li>',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            else if(capacity == 0) {
                output.push('You are producing an insignificant amount of ore. Add more platforms or upgrade your Mining Ministry.');
            }
            else if(capacity > 100) {
                output.push('You are producing more than your ships can handle. Add more ship to bring the value closer to 100.');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        _getPlatformTab : function() {
            this.platformTab = new YAHOO.widget.Tab({ label: "Platforms", content: [
                '<div id="platformShippingInfo"></div>',
                '<div class="platformContainer">',
                '    <div id="platformDetails">',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        _getAbandonAllPlatformsTab : function() {
            this.probesTab = new YAHOO.widget.Tab({ label: "Abandon All Platforms", content: [
                    '<div>',
                    '    <button type="button" id="miningMinistryBigRedButton">Abandon All Platforms!</button>',
                    '</div>'

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        nLi.innerHTML = ['<img src="',Lib.AssetUrl,'star_system/',obj.asteroid.image,'.png" />',obj.asteroid.name].join('');

• Read up
  Read up