Sign upLogin

plainblack/Lacuna-Web-Client

View on GitHub
Star
app/js-yui/building/network19.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function NewsGet has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        NewsGet : function() {
            require('js/actions/menu/loader').show();
            this.service.view_news({session_id:Game.GetSession(),building_id:this.building.id}, {
                success : function(o){
                    YAHOO.log(o, "info", "Network19.NewsGet.success");
Severity: Minor
Found in app/js-yui/building/network19.js - About 1 hr to fix

    Function success has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                    success : function(o){
                    YAHOO.log(o, "info", "Network19.NewsGet.success");
                    require('js/actions/menu/loader').hide();
                    this.rpcSuccess(o);
    Severity: Minor
    Found in app/js-yui/building/network19.js - About 1 hr to fix

      Similar blocks of code found in 17 locations. Consider refactoring.
      Open

          var Lang = YAHOO.lang,
        Util = YAHOO.util,
        Dom = Util.Dom,
        Event = Util.Event,
        Sel = Util.Selector,
      Severity: Major
      Found in app/js-yui/building/network19.js and 16 other locations - About 1 hr to fix
      app/js-yui/building.js on lines 8..15
      app/js-yui/building/development.js on lines 6..13
      app/js-yui/building/distributionCenter.js on lines 6..13
      app/js-yui/building/geneticsLab.js on lines 6..13
      app/js-yui/building/missionCommand.js on lines 6..13
      app/js-yui/building/park.js on lines 6..13
      app/js-yui/building/planetaryCommand.js on lines 13..20
      app/js-yui/building/shipyard.js on lines 6..13
      app/js-yui/building/spaceStationLab.js on lines 6..13
      app/js-yui/login.js on lines 13..20
      app/js-yui/mapPlanet.js on lines 12..19
      app/js-yui/mapStar.js on lines 8..15
      app/js-yui/module/parliament.js on lines 6..13
      app/js-yui/module/stationCommand.js on lines 6..13
      app/js-yui/profile.js on lines 13..20
      app/js-yui/stats.js on lines 12..19

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status