plainblack/Lacuna-Web-Client

File planetaryCommand.js has 346 lines of code (exceeds 250 allowed). Consider refactoring.

Open

YAHOO.namespace("lacuna.buildings");

var $ = require('js/shims/jquery');

var MapActions = require('js/actions/menu/map');

Function _getResourcesTab has 57 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _getResourcesTab : function() {

            var food_items = '',
                foods      = Lib.ResourceTypes.food;

Function _getPlanetTab has 54 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _getPlanetTab : function() {
            var planet = this.result.planet;
            var details = function(type,imgclass) {
                var Type = Lib.capitalizeFirstLetter(type);
                var stored   = planet[type+"_stored"] || planet[type];

Function PlanPopulate has 43 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        PlanPopulate : function(){
            var div = Dom.get("planDetails");
            if(div) {
                var divParent = div.parentNode,
                    ul = document.createElement("ul"),

Function Abandon has 40 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        Abandon : function() {
            var cp = Game.GetCurrentPlanet();
            if(confirm(['Are you sure you want to abandon ',cp.name,'?'].join(''))) {
                require('js/actions/menu/loader').show();
                Game.Services.Body.abandon({

Function Rename has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        Rename : function() {
            var newName = Dom.get("commandPlanetNewName").value,
                cp = Game.GetCurrentPlanet(),
                planetId = cp.id;
            Game.Services.Body.rename({

Function success has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

                success : function(o){
                    YAHOO.log(o, "info", "PlanetaryCommand.abandon.success");
                    this.rpcSuccess(o);

                    delete Game.EmpireData.planets[cp.id]; // Remove the abandoned planet

Function _getPlanTab has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _getPlanTab : function() {
            this.planTab = new YAHOO.widget.Tab({ label: "Plans", content: [
                '<ul class="plan planHeader clearafter"><li class="planQuan">Quantity</li><li class="planName">Name</li><li class="planLevel">Level</li><li class="planExtra">Extra Level</li></ul>',
                '<div>',
                '    <div id="planDetails">',

Avoid deeply nested control flow statements.

Open

                            if(tile) {
                                if(tile.domElement) {
                                    var domEl = tile.domElement; // get the element
                                    var childEl = domEl.childNodes[1]; // find the alignment child
                                    if(childEl) {

Avoid deeply nested control flow statements.

Open

                            if(Lacuna.MapStar._map.tileCache[cp.x] && Lacuna.MapStar._map.tileCache[cp.x][cp.y]) {
                                delete Lacuna.MapStar._map.tileCache[cp.x][cp.y]; // Remove the planet from the cache
                            }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            for(x=0; x < ores.length; x++) {
                ore = ores[x];

                ore_items += [
                    '<li><label>',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            for(x=0; x < foods.length; x++) {
                food = foods[x];

                food_items += [
                    '<li><label>',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if(e.newValue) {
                    if(!this.plans) {
                        require('js/actions/menu/loader').show();
                        this.service.view_plans({session_id:Game.GetSession(),building_id:this.building.id}, {
                            success : function(o){

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            ore_items += [
                    '<li><label>Energy</label><span class="pcStored" title="', Lib.formatNumber(this.result.planet.energy_stored),'">',
                    Lib.convertNumDisplay(this.result.planet.energy_stored),
                    '</span> @ <span class="pcPerHour" title="',Lib.formatNumber(this.result.planet.energy_hour),'">',
                    Lib.convertNumDisplay(this.result.planet.energy_hour),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            ore_items += [
                    '<li><label>Water</label><span class="pcStored" title="', Lib.formatNumber(this.result.planet.water_stored),'">',
                    Lib.convertNumDisplay(this.result.planet.water_stored),
                    '</span> @ <span class="pcPerHour" title="',Lib.formatNumber(this.result.planet.water_hour),'">',
                    Lib.convertNumDisplay(this.result.planet.water_hour),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                            if(Lacuna.MapStar._map.tileCache[cp.x] && Lacuna.MapStar._map.tileCache[cp.x][cp.y]) {
                                delete Lacuna.MapStar._map.tileCache[cp.x][cp.y]; // Remove the planet from the cache
                            }

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

                setTimeout(function() {
                    var Ht = Game.GetSize().h - 170;
                    if(Ht > 300) { Ht = 300; }
                    Dom.setStyle(divParent,"height",Ht + "px");
                    Dom.setStyle(divParent,"overflow-y","auto");

• Read up
  Read up

Similar blocks of code found in 17 locations. Consider refactoring.

Open

    var Lang = YAHOO.lang,
        Util = YAHOO.util,
        Dom = Util.Dom,
        Event = Util.Event,
        Sel = Util.Selector,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    failure : function(o){
                        Dom.get("commandPlanetRenameMessage").innerHTML = o.error.message;
                        Lib.fadeOutElm("commandPlanetRenameMessage");
                        return true;
                    },

• Read up
  Read up