plainblack/Lacuna-Web-Client

File shipyard.js has 330 lines of code (exceeds 250 allowed). Consider refactoring.

Open

YAHOO.namespace("lacuna.buildings");

if (typeof YAHOO.lacuna.buildings.Shipyard == "undefined" || !YAHOO.lacuna.buildings.Shipyard) {
    
(function(){

Function ShipPopulate has 68 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        ShipPopulate : function() {
            var details = Dom.get("shipDetails");
            
            if(details) {
                var ships = this.ships.buildable,

Function ShipyardDisplay has 40 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        ShipyardDisplay : function() {
            var bq = this.ship_build_queue,
                div = Dom.get("shipsBuilding");

            if(div) {

Function ShipBuild has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        ShipBuild : function(e) {
            var btn = Event.getTarget(e);
            btn.disabled = true;
            require('js/actions/menu/loader').show();
            var qty = Dom.get("ship_"+this.Type);

Function _getBuildTab has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _getBuildTab : function() {
            var buildTab = new YAHOO.widget.Tab({ label: "Build Ships", content: [
                '<div>',
                '    <div class="clearafter" style="font-weight:bold;">',
                '        <span id="shipDocksAvailable" style="float:left;"></span>',

Avoid deeply nested control flow statements.

Open

                        if(filter == "All") {
                            shipNames.push(shipType);
                        }
                        else if(filter == "Now" && ships[shipType].can) {
                            shipNames.push(shipType);

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            buildTab.subscribe("activeChange", function(e) {
                if(e.newValue) {
                    this.getBuild();
                    var Ht = Game.GetSize().h - 190;
                    if(Ht > 300) { Ht = 300; }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            queueTab.subscribe("activeChange", function(e) {
                if(e.newValue) {
                    this.getQueue();
                    var Ht = Game.GetSize().h - 210;
                    if(Ht > 300) { Ht = 300; }

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        ShipyardQueue : function(remaining, elLine){
            var compTime;
            if(remaining <= 0) {
                compTime = 'Overdue ' + Lib.formatTime(Math.round(-remaining));
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                this.service.view_build_queue({session_id:Game.GetSession(),building_id:this.building.id,page_number:1}, {
                    success : function(o){
                        YAHOO.log(o, "info", "Shipyard.getQueue.view_build_queue.success");
                        require('js/actions/menu/loader').hide();
                        this.rpcSuccess(o);

• Read up
  Read up

Similar blocks of code found in 17 locations. Consider refactoring.

Open

    var Lang = YAHOO.lang,
        Util = YAHOO.util,
        Dom = Util.Dom,
        Event = Util.Event,
        Sel = Util.Selector,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    if(ship.can) {
                        Event.on(Sel.query("button", nLi, true), "click", this.ShipBuild, {Self:this,Type:shipName,Ship:ship}, true);
                    }

• Read up
  Read up