plainblack/Lacuna-Web-Client

File spacePort.js has 1301 lines of code (exceeds 250 allowed). Consider refactoring.

Open

// Stuff to do for FleetSend:
// Make sure clicking send only sends the correct ship
// On click of "Get Available Groups of Ships for Target" disable sends that would not arrive before arrival time.
YAHOO.namespace("lacuna.buildings");

Function ViewPopulate has 77 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        ViewPopulate : function() {
            var details = Dom.get("shipsViewDetails");

            if(details) {
                var ships = this.shipsView.ships,

Function LogsPopulate has 73 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        LogsPopulate : function() {
            var details = Dom.get("battleLogsDetails");

            if(details) {
                var logs = this.battleLogs.battle_log,

Function FleetSend has 71 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        FleetSend : function(e) {
            var btn = Event.getTarget(e);
            btn.disabled = true;
            var oSelf = this.Self,
                ship = this.Ship,

Function OrbitingPopulate has 71 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        OrbitingPopulate : function() {
            var details = Dom.get("shipsOrbitingDetails");

            if(details) {
                var ships = this.shipsOrbiting.ships,

Function ForeignPopulate has 67 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        ForeignPopulate : function() {
            var details = Dom.get("shipsForeignDetails");

            if(details) {
                var ships = this.shipsForeign.ships,

Function SpacePortPopulate has 60 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        SpacePortPopulate : function() {
            var ships = this.shipsTravelling.ships_travelling,
                details = Dom.get("shipDetails");

            if(details) {

Function PopulateFleetSendTab has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        PopulateFleetSendTab : function(target, ships) {
            var details = Dom.get("sendFleetAvail"),
                detailsParent = details.parentNode,
                li = document.createElement("li");

Function _getSendFleetTab has 55 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _getSendFleetTab : function() {
            var currYear  = Lacuna.Game.ServerData.time.getUTCFullYear();
            var currMon   = Lacuna.Game.ServerData.time.getUTCMonth() + 1;
            var currDay   = Lacuna.Game.ServerData.time.getUTCDate();
            var currHour  = Lacuna.Game.ServerData.time.getUTCHours();

Function PopulateShipsSendTab has 50 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        PopulateShipsSendTab : function(target, ships) {
            var details = Dom.get("sendShipAvail"),
                detailsParent = details.parentNode,
                li = document.createElement("li");

Function ViewActionDetails has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        ViewActionDetails : function(nLi, ship, noEvent) {
            var ulDet = ['<li style="white-space:nowrap;"><label style="font-weight:bold;">',ship.task,'</label></li>'];

            if(ship.task === "Docked") {
                ulDet[ulDet.length] = '<li style="white-space:nowrap;margin-top:5px"><button type="button" class="scuttle">Scuttle</button></li>';

Function ShipScuttle has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        ShipScuttle : function(e, matchedEl, container) {
            if(confirm(["Are you sure you want to Scuttle ",this.Ship.name,"?"].join(''))) {
                var btn = Event.getTarget(e);
                btn.disabled = true;
                require('js/actions/menu/loader').show();

Function ShipRecall has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        ShipRecall : function(e, matchedEl, container) {
            matchedEl.disabled = true;
            require('js/actions/menu/loader').show();

            this.Self.service.recall_ship({

Function getShips has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        getShips : function(e) {
            if(e.newValue) {
                if(!this.shipsView) {
                    require('js/actions/menu/loader').show();
                    this.service.view_all_ships({session_id:Game.GetSession(),building_id:this.building.id,paging:{page_number:1}}, {

Function getLogs has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        getLogs : function(e) {
            if(e.newValue) {
                if(!this.battleLogs) {
                    require('js/actions/menu/loader').show();
                    this.service.view_battle_logs({session_id:Game.GetSession(),building_id:this.building.id}, {

Function getTravel has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        getTravel : function(e) {
            if(e.newValue) {
                if(!this.shipsTravelling) {
                    require('js/actions/menu/loader').show();
                    this.service.view_ships_travelling({session_id:Game.GetSession(),building_id:this.building.id,page_number:1}, {

Function ShipSend has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        ShipSend : function(e) {
            var btn = Event.getTarget(e);
            btn.disabled = true;

            var oSelf = this.Self,

Function getForeign has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        getForeign : function(e) {
            if(e.newValue) {
                if(!this.shipsForeign) {
                    require('js/actions/menu/loader').show();
                    this.service.view_foreign_ships({session_id:Game.GetSession(),building_id:this.building.id,page_number:1}, {

Function getOrbiting has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        getOrbiting : function(e) {
            if(e.newValue) {
                if(!this.shipsOrbiting) {
                    require('js/actions/menu/loader').show();
                    this.service.view_ships_orbiting({session_id:Game.GetSession(),building_id:this.building.id}, {

Function ShipNameSave has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        ShipNameSave : function(e) {
            Event.stopEvent(e);
            require('js/actions/menu/loader').show();
            var newName = this.Input.value;

Avoid deeply nested control flow statements.

Open

                        if(ship.from.empire && ship.from.empire.name) {
                            nLi.innerHTML = ship.from.name + ' <span style="cursor:pointer;">[' + ship.from.empire.name + ']</span>';
                            Event.on(nLi, "click", this.EmpireProfile, ship.from.empire);
                        }
                        else {

Avoid deeply nested control flow statements.

Open

                        if(ship.from.empire && ship.from.empire.name) {
                            nLi.innerHTML = ship.from.name + ' <span style="cursor:pointer;">[' + ship.from.empire.name + ']</span>';
                            Event.on(nLi, "click", this.EmpireProfile, ship.from.empire);
                        }
                        else {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        ForeignPopulate : function() {
            var details = Dom.get("shipsForeignDetails");

            if(details) {
                var ships = this.shipsForeign.ships,

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        getTravel : function(e) {
            if(e.newValue) {
                if(!this.shipsTravelling) {
                    require('js/actions/menu/loader').show();
                    this.service.view_ships_travelling({session_id:Game.GetSession(),building_id:this.building.id,page_number:1}, {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        getForeign : function(e) {
            if(e.newValue) {
                if(!this.shipsForeign) {
                    require('js/actions/menu/loader').show();
                    this.service.view_foreign_ships({session_id:Game.GetSession(),building_id:this.building.id,page_number:1}, {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        ShipName : function() {
            this.el.innerHTML = "";

            var inp = document.createElement("input"),
                bSave = document.createElement("button"),

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        ShipHandlePagination : function(newState) {
            require('js/actions/menu/loader').show();
            this.service.view_ships_travelling({
                session_id:Game.GetSession(),
                building_id:this.building.id,

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        ForeignHandlePagination : function(newState) {
            require('js/actions/menu/loader').show();
            this.service.view_foreign_ships({
                session_id:Game.GetSession(),
                building_id:this.building.id,

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        LogsHandlePagination : function(newState) {
            require('js/actions/menu/loader').show();
            this.service.view_battle_logs({
                session_id:Game.GetSession(),
                building_id:this.building.id,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(type === "xy") {
                target.x = Dom.get("sendFleetTargetX").value;
                target.y = Dom.get("sendFleetTargetY").value;
                Dom.get("sendFleetNote").innerHTML = ['X: ', target.x, ' - Y: ', target.y].join('');
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(type === "xy") {
                target.x = Dom.get("sendShipTargetX").value;
                target.y = Dom.get("sendShipTargetY").value;
                Dom.get("sendShipNote").innerHTML = ['X: ', target.x, ' - Y: ', target.y].join('');
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            this.service.get_ships_for({
                session_id:Game.GetSession(),
                from_body_id:Game.GetCurrentPlanet().id,
                target:target
            }, {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            this.service.get_fleet_for({
                session_id:Game.GetSession(),
                from_body_id:Game.GetCurrentPlanet().id,
                target:target
            }, {

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        SpacePortQueue : function(remaining, elLine){
            var arrTime;
            if(remaining <= 0) {
                arrTime = 'Overdue ' + Lib.formatTime(Math.round(-remaining));
            }

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        ForeignQueue : function(remaining, elLine){
            var arrTime;
            if(remaining <= 0) {
                arrTime = 'Overdue ' + Lib.formatTime(Math.round(-remaining));
            }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        _getForeignTab : function() {
            this.foreignShipsTab = new YAHOO.widget.Tab({ label: "Incoming", content: [
                '<div>',
                '    <ul class="shipHeader shipInfo clearafter">',
                '        <li class="shipTypeImage">&nbsp;</li>',

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

        _getLogsTab : function() {
            this.battleLogsTab = new YAHOO.widget.Tab({ label: "Battle Logs", content: [
                '<div>',
                '    <ul class="shipHeader shipInfo clearafter" style="padding-left:5px; padding-right:5px;">',
                '        <li class="shipTask">Role</li>',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            Event.on("sendShipType", "change", function(){
                if(Lib.getSelectedOptionValue(this) === "xy") {
                    Dom.setStyle("sendShipTargetSelectText", "display", "none");
                    Dom.setStyle("sendShipTargetSelectXY", "display", "");
                }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            Event.on("sendFleetType", "change", function(){
                if(Lib.getSelectedOptionValue(this) === "xy") {
                    Dom.setStyle("sendFleetTargetSelectText", "display", "none");
                    Dom.setStyle("sendFleetTargetSelectXY", "display", "");
                }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        _getOrbitingTab : function() {
            this.viewOrbitingTab = new YAHOO.widget.Tab({ label: "Foreign Orbiting", content: [
                '<div>',
                '    <ul class="shipHeader shipInfo clearafter">',
                '        <li class="shipTypeImage">&nbsp;</li>',

• Read up
  Read up

Identical blocks of code found in 5 locations. Consider refactoring.

Open

    var Lang = YAHOO.lang,
        Util = YAHOO.util,
        Dom = Util.Dom,
        Event = Util.Event,
        Sel = Util.Selector,

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

            setTimeout(function() {
                var Ht = Game.GetSize().h - 250;
                if(Ht > 250) { Ht = 250; }
                Dom.setStyle(detailsParent,"height",Ht + "px");
                Dom.setStyle(detailsParent,"overflow-y","auto");

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

            setTimeout(function() {
                var Ht = Game.GetSize().h - 250;
                if(Ht > 250) { Ht = 250; }
                Dom.setStyle(detailsParent,"height",Ht + "px");
                Dom.setStyle(detailsParent,"overflow-y","auto");

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                        if(info) {
                            this.Self.result.docks_available++;
                            info.innerHTML = ['This SpacePort can dock a maximum of ', this.Self.result.max_ships, ' ships. There are ', this.Self.result.docks_available, ' docks available.'].join('');
                        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                    if(info) {
                        this.Self.result.docks_available++;
                        info.innerHTML = ['This SpacePort can dock a maximum of ', this.Self.result.max_ships, ' ships. There are ', this.Self.result.docks_available, ' docks available.'].join('');
                    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            return [this._getTravelTab(), this._getViewTab(), this._getOrbitingTab(), this._getForeignTab(), this._getLogsTab(), this._getSendTab(), this._getSendFleetTab()];

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            this.Self.service.name_ship({
                session_id:Game.GetSession(),
                building_id:this.Self.building.id,
                ship_id:this.Ship.id,
                name:newName

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            this.travelTab = new YAHOO.widget.Tab({ label: "Travelling", content: [
                '<div>',
                '    <div style="overflow:auto;margin-top:2px;">',
                '        <ul id="shipDetails"></ul>',
                '    </div>',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                failure : function(o){
                    if(this.Input) {
                        this.Input.value = this.Ship.name;
                    }
                },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if(!noEvent) {
                    Event.delegate(nLi, 'click', this.ShipScuttle, 'button.scuttle', {Self:this,Ship:ship,Line:nLi}, true);
                }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if(!noEvent) {
                    Event.delegate(nLi, 'click', this.ShipRecall, 'button.recall', {Self:this,Ship:ship,Line:nLi}, true);
                }

• Read up
  Read up