Sign upLogin

plainblack/Lacuna-Web-Client

View on GitHub
Star
app/js-yui/building/wasteExchanger.js

Summary

Maintainability
F
3 wks
Test Coverage

Function RecycleGetDisplay has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        RecycleGetDisplay : function(recycle) {
            var planet = Game.GetCurrentPlanet(),
                ul = document.createElement("ul"),
                li = document.createElement("li"),
                nLi = li.cloneNode(false),
Severity: Major
Found in app/js-yui/building/wasteExchanger.js - About 4 hrs to fix

    File wasteExchanger.js has 304 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    YAHOO.namespace("lacuna.buildings");

if (typeof YAHOO.lacuna.buildings.WasteExchanger == "undefined" || !YAHOO.lacuna.buildings.WasteExchanger) {
    
(function(){
    Severity: Minor
    Found in app/js-yui/building/wasteExchanger.js - About 3 hrs to fix

      Function Recycle has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              Recycle : function(e, options) {
            var planet = Game.GetCurrentPlanet();
            if(planet) {
                var ore = this.recycleOreEl.value*1,
                    water = this.recycleWaterEl.value*1,
      Severity: Minor
      Found in app/js-yui/building/wasteExchanger.js - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

        if (typeof YAHOO.lacuna.buildings.WasteExchanger == "undefined" || !YAHOO.lacuna.buildings.WasteExchanger) {
    
(function(){
    var Lang = YAHOO.lang,
        Util = YAHOO.util,
        Severity: Critical
        Found in app/js-yui/building/wasteExchanger.js - About 1 hr to fix

          Function MaxValue has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  MaxValue : function(e) {
            var btn = Event.getTarget(e),
                input = btn.input,
                cp = Game.GetCurrentPlanet(),
                origVal, newVal;
          Severity: Minor
          Found in app/js-yui/building/wasteExchanger.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                            if(this.work && this.work.seconds_remaining && this.work.seconds_remaining*1 > 0) {
                                    ce.appendChild(this.RecycleGetTimeDisplay(o.result.recycle, water, ore, energy));
                                    this.addQueue(this.work.seconds_remaining, this.RecycleQueue, "recycleTime", this);
                                }
                                else {
            Severity: Major
            Found in app/js-yui/building/wasteExchanger.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              if (typeof YAHOO.lacuna.buildings.WasteExchanger == "undefined" || !YAHOO.lacuna.buildings.WasteExchanger) {
    
(function(){
    var Lang = YAHOO.lang,
        Util = YAHOO.util,
              Severity: Major
              Found in app/js-yui/building/wasteExchanger.js and 1 other location - About 3 wks to fix
              app/js-yui/building/wasteRecycling.js on lines 3..344

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 4026.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status