plainblack/Lacuna-Web-Client

File mapPlanet.js has 925 lines of code (exceeds 250 allowed). Consider refactoring.

Open

YAHOO.namespace("lacuna");

var _ = require('lodash');

var WindowManagerActions    = require('js/actions/windowManager');

Function _buildBuilderPanel has 287 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _buildBuilderPanel : _.once(function() {
            var panelId = "buildingBuilder";

            var panel = document.createElement("div");
            panel.id = panelId;

Function updateDisplay has 128 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            this.buildingBuilder.updateDisplay = function() {
                var mainTag = this.mainTag;
                var subTag = this.subTag;
                var b = this.buildable[mainTag] || this.buildable[subTag];
                var list = this.buildingList;

Function _buildDetailsPanel has 108 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _buildDetailsPanel : _.once(function() {
            var panelId = "buildingDetails";
            var panel = document.createElement("div");
            panel.id = panelId;
            panel.innerHTML = ['<div class="hd">Details</div>',

Consider simplifying this complex logical expression.

Open

if (typeof YAHOO.lacuna.MapPlanet == "undefined" || !YAHOO.lacuna.MapPlanet) {

(function(){
    var Lang = YAHOO.lang,
        Util = YAHOO.util,

Function DetailsProcess has 56 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        DetailsProcess : function(oResults, url, x, y) {
            var building = oResults.building,
                panel = this.buildingDetails,
                currBuildingId = this.currentBuilding ? this.currentBuilding.building.id : undefined;
            if(panel.isVisible() && (currBuildingId != oResults.building.id)) {

Function Mapper has 47 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        Mapper : function(oArgs) {
            //YAHOO.log(oArgs.buildings, "debug", "Mapper");
            this.buildings = oArgs.buildings;
            this.surfaceUrl = [Lib.AssetUrl,'planet_side/',oArgs.body.surface_image,'.jpg'].join('');
            Dom.setStyle("buildingDetailsImgBkgd","background",['transparent url(',this.surfaceUrl,') no-repeat left top'].join(''));

Function DetailsView has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        DetailsView : function(tile) {
            //YAHOO.log(tile, "info", "DetailsView");

            if (!FactoryMap[tile.data.url]) {
                // Pass this off to the new React stuff.

Function Build has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        Build : function(building, x, y) {
            if(this.NotIsolationist(building)) {
                return;
            }

Function ViewData has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        ViewData : function(id, url, callback, x, y) {
            var BuildingServ = Game.Services.Buildings.Generic,
                data = {
                    session_id: Game.GetSession(""),
                    building_id: id

Avoid deeply nested control flow statements.

Open

                            if (extra_level) {
                                reason = "Will build to level " + (extra_level + 1) + " for free with plan.";
                            }
                            else {
                                reason = "Will build for free with plan.";

Avoid deeply nested control flow statements.

Open

                        if(!Dom.inDocument(this._elGrid)) {
                            document.getElementById("content").appendChild(this._elGrid);
                        }

Avoid deeply nested control flow statements.

Open

                            if(filters[tags[t]]){
                                filterMatch++;
                            }

Avoid deeply nested control flow statements.

Open

                                if(rf <= 0) {
                                    elm.innerHTML = "";
                                    YAHOO.log("Complete","info","buildingDetails.showEvent.BuildTimeRemaining");
                                    this.DetailsView({data:{id:building.id,url:building.url},x:building.x,y:building.y});
                                }

Function ViewData has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

        ViewData : function(id, url, callback, x, y) {

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            this.buildingDetails.addQueue = function(seconds, queueFn, elm, sc) {
                this.queue = this.queue || [];
                //check if the queue is empty and store
                var notStarted = this.queue.length == 0;
                //push new queue item so it's immediately available for the tick

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            this.buildingBuilder = new YAHOO.widget.Panel(panelId, {
                constraintoviewport:true,
                visible:false,
                draggable:true,
                effect:Game.GetContainerEffect(),

• Read up
  Read up

Similar blocks of code found in 17 locations. Consider refactoring.

Open

    var Lang = YAHOO.lang,
        Util = YAHOO.util,
        Dom = Util.Dom,
        Event = Util.Event,
        Sel = Util.Selector,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        SetSize : function() {
            var size = Game.GetSize();
            Dom.setStyle(this._elGrid, "width", size.w+"px");
            Dom.setStyle(this._elGrid, "height", size.h+"px");
        },

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                while(panel.tabView.get("tabs").length > 0){
                    var tab = panel.tabView.getTab(0);
                    Event.purgeElement(tab.get("contentEl"));
                    panel.tabView.removeTab(tab);
                }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                    while(panel.tabView.get("tabs").length > 0){
                        var tab = panel.tabView.getTab(0);
                        Event.purgeElement(tab.get("contentEl"));
                        panel.tabView.removeTab(tab);
                    }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

            this.buildingDetails.resetQueue = function() {
                Game.onTick.unsubscribe(this.processQueue);
                this.queue = [];
            };

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                    if(visible) {
                        if(!Dom.inDocument(this._elGrid)) {
                            document.getElementById("content").appendChild(this._elGrid);
                        }
                        //Dom.setStyle(this._elGrid, "display", visible ? "" : "none");

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        _fireSelectTab : function(tabIndex) {
            if(this.buildingDetails.isVisible()) {
                this.buildingDetails.tabView.selectTab(tabIndex);
            }
        },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        _fireAddTab : function(tab) {
            if(this.buildingDetails.isVisible()) {
                this.buildingDetails.tabView.addTab(tab);
            }
        },

• Read up
  Read up