plainblack/Lacuna-Web-Client

File textboxList.js has 545 lines of code (exceeds 250 allowed). Consider refactoring.

Open

YAHOO.namespace("lacuna");

//only load this once
if (typeof YAHOO.lacuna.TextboxList == "undefined" || !YAHOO.lacuna.TextboxList) {

Function TBL has 109 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    var TBL = function(elInput, oDataSource, oConfigs) {
        if(!oConfigs){ oConfigs = {}; }
        oConfigs.useShadow = oConfigs.useShadow || false;
        oConfigs.useIFrame = oConfigs.useIFrame || true;
        oConfigs.animVert = oConfigs.animVert || false;

Function _populateList has 81 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _populateList : function(sQuery, oResponse, oPayload) {
            // Clear previous timeout
            if(this._nTypeAheadDelayID != -1) {
                clearTimeout(this._nTypeAheadDelayID);
            }

Consider simplifying this complex logical expression.

Open

if (typeof YAHOO.lacuna.TextboxList == "undefined" || !YAHOO.lacuna.TextboxList) {

// enclose everything in an anonymous function ...
(function () {
    // ... so that variables that you declare inside are local to the function and invisible outside

Function _updateDirty has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _updateDirty : function() {
            //only update dirty if it's not a select
            if(!this._singleRequest) {
                var isDirty;
                if(this.multiSelect){

Avoid deeply nested control flow statements.

Open

                        for(var j = allListItemEls.length-1; j >= nItemsToShow; j--) {
                            extraListItem = allListItemEls[j];
                            extraListItem.style.display = "none";
                        }

Avoid deeply nested control flow statements.

Open

                        for(var key in cur) {
                            //if the key actually has a value count it
                            if(cur[key]) {
                                curNum++;
                            }

Avoid deeply nested control flow statements.

Open

                        if(elListItem._oResultData && queue.indexOf(String(elListItem._oResultData.Id)) >= 0) {
                            this._selectItem(elListItem);
                        }

Avoid deeply nested control flow statements.

Open

                        if(oSelf.beforeDeleteEvent.fire(target)) {
                            delete oSelf._oTblSelections[target._value];
                            oSelf._elTblList.removeChild(target);
                            oSelf._updateDirty();
                        }

Avoid deeply nested control flow statements.

Open

                        if(curNum != orig.length) {
                            isDirty = true;
                        }

Avoid deeply nested control flow statements.

Open

                        if(!cur[orig[s]]) {
                            isDirty = true;
                            break;
                        }

Avoid deeply nested control flow statements.

Open

                        if(this.resultTypeList) {
                            // Results need to be converted back to an array
                            var aResult = [];
                            // Match key is first
                            aResult[0] = (YAHOO.lang.isString(oResult)) ? oResult : oResult[sMatchKey] || oResult[this.key];

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            for(var bitKey in this._oTblSelections) {
                var bit = this._oTblSelections[bitKey];
                Dom.removeClass(bit, CSS_PREFIX + "Disabled");
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            for(var bitKey in this._oTblSelections) {
                var bit = this._oTblSelections[bitKey];
                Dom.addClass(bit, CSS_PREFIX + "Disabled");
            }

• Read up
  Read up