Sign upLogin

plainblack/Lacuna-Web-Client

View on GitHub
Star

Showing 509 of 1,320 total issues

Function spiesView has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        spiesView : function(e) {
            if(e.newValue) {
                if(!this.spies) {
                    require('js/actions/menu/loader').show();
                    this.service.view_foreign_spies({session_id:Game.GetSession(),building_id:this.building.id}, {
Severity: Minor
Found in app/js-yui/building/security.js - About 1 hr to fix

    Function _getLawsTab has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _getLawsTab : function() {
            var tab = new YAHOO.widget.Tab({ label: "Laws", content: [
                '<div>',
                '    <div style="overflow:auto;"><ul id="lawsDetails"></ul></div>',
                '</div>'
    Severity: Minor
    Found in app/js-yui/module/parliament.js - About 1 hr to fix

      Function EvictMining has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              EvictMining: function(e) {
            var button   = Event.getTarget(e),
                platform = Lib.getSelectedOptionValue('proposeEvictMiningId');

            button.disabled = true;
      Severity: Minor
      Found in app/js-yui/module/parliament.js - About 1 hr to fix

        Function _getPropsTab has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                _getPropsTab : function() {
            var tab = new YAHOO.widget.Tab({ label: "Propositions", content: [
                '<div>',
                '    <div style="overflow:auto;"><ul id="propsDetails"></ul></div>',
                '</div>'
        Severity: Minor
        Found in app/js-yui/module/parliament.js - About 1 hr to fix

          Function _getBuildTab has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  _getBuildTab : function() {
            var buildTab = new YAHOO.widget.Tab({ label: "Build Ships", content: [
                '<div>',
                '    <div class="clearafter" style="font-weight:bold;">',
                '        <span id="shipDocksAvailable" style="float:left;"></span>',
          Severity: Minor
          Found in app/js-yui/building/shipyard.js - About 1 hr to fix

            Function _setTab has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    _setTab : function(el) {
            var list = this.list;
            Event.purgeElement(list, true);
            list.innerHTML = "";
            Dom.removeClass([this.create,this.inbox,this.alerts,this.intel,this.medals,this.tutorial,this.sent,this.archive,this.trash,this.announce], "selected");
            Severity: Minor
            Found in app/js-yui/messaging.js - About 1 hr to fix

              Function titleCaps has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  String.prototype.titleCaps = function(replaceVal, withVal){
        var parts = [], split = /[:.;?!] |(?: |^)["�]/g, index = 0, processVal = this;
        var fnUpper = function(all){
                return (/[A-Za-z]\.[A-Za-z]/).test(all) ? all : String.upper(all);
            },
              Severity: Minor
              Found in app/js-yui/library.js - About 1 hr to fix

                Function Tile has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    var Tile = function(x, y, z, ox, oy, layer) {
        this.z = z;
        this.x = x;
        this.y = y;
        this.offsetX = ox;
                Severity: Minor
                Found in app/js-yui/mapper.js - About 1 hr to fix

                  Function refresh has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          refresh : function() {
            var obj = this.map.getTile(this.x,this.y,this.z);
            this.blank = obj.blank;
            this.image = obj.image;
            this.url = obj.url;
                  Severity: Minor
                  Found in app/js-yui/mapper.js - About 1 hr to fix

                    Function fetch has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            fetch: function(url, callback) {
            if(YAHOO.rpc.Service._smdCache[url]) {
                this._smd = YAHOO.rpc.Service._smdCache[url];
                this.process(callback);
            }
                    Severity: Minor
                    Found in app/js-yui/rpc.js - About 1 hr to fix

                      Function success has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                                      success : function(o){
                    this.rpcSuccess(o);
                    if(hasResources) {
                        this.getStoredResources(true);
                    }
                      Severity: Minor
                      Found in app/js-yui/building/transporter.js - About 1 hr to fix

                        Function SpyNameSave has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                SpyNameSave : function(e) {
            Event.stopEvent(e);
            require('js/actions/menu/loader').show();
            var newName = this.Input.value;
                        Severity: Minor
                        Found in app/js-yui/building/intelligence.js - About 1 hr to fix

                          Function PropsPopulate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  PropsPopulate : function() {
            var details = Dom.get("propsDetails");
            
            if(details) {
                var props = this.props,
                          Severity: Minor
                          Found in app/js-yui/building/embassy.js - About 1 hr to fix

                            Function success has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                            success : function(o){
                    this.rpcSuccess(o);
                    if(hasResources) {
                        this.getStoredResources(true);
                    }
                            Severity: Minor
                            Found in app/js-yui/building/tradeMinistry.js - About 1 hr to fix

                              Function MapVisible has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      MapVisible : function(visible) {
            if(visible) {
                // Build panels
                this._buildFindPanel();
                this._buildDetailsPanel();
                              Severity: Minor
                              Found in app/js-yui/mapStar.js - About 1 hr to fix

                                Function PropsPopulate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                        PropsPopulate : function() {
            var details = Dom.get("propsDetails");
            
            if(details) {
                var props = this.props,
                                Severity: Minor
                                Found in app/js-yui/module/parliament.js - About 1 hr to fix

                                  Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      render : function() {
        return (
            <div className="ui teal labels">

                <div className="ui label">
                                  Severity: Minor
                                  Found in app/js/components/window/spyTraining/spyTrainingStatus.jsx - About 1 hr to fix

                                    Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                        render : function() {
        var body = this.props.body;

        var hour     = body[this.props.type + '_hour'];
        var stored   = body[this.props.type + '_stored'] || body[this.props.type] || 0;
                                    Severity: Minor
                                    Found in app/js/components/menu/bottomBar/resourceToolTip.jsx - About 1 hr to fix

                                      Function isEventSupported has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                                      var isEventSupported = (function() {
                    var TAGNAMES = {
                        'select' : 'input',
                        'change' : 'input',
                        'submit' : 'form',
                                      Severity: Minor
                                      Found in app/js/game.jsx - About 1 hr to fix

                                        Function QueueProcess has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                                    QueueProcess : function(e, oArgs) {
                // only do anything if the queue actually has data
                if (Game.queue) {
                    var toFire = {};
                    var tickMS = oArgs[0];
                                        Severity: Minor
                                        Found in app/js/game.jsx - About 1 hr to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language