plainblack/Lacuna-Web-Client

View on GitHub

Showing 509 of 1,320 total issues

Function _getPlanetTab has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        _getPlanetTab : function() {
            var planet = this.result.planet;
            var details = function(type,imgclass) {
                var Type = Lib.capitalizeFirstLetter(type);
                var stored   = planet[type+"_stored"] || planet[type];
Severity: Major
Found in app/js-yui/building/planetaryCommand.js - About 2 hrs to fix

    Function incomingSupplyChainList has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            incomingSupplyChainList : function() {
              var supply_chains = this.incoming_supply_chains;
    
              if ( supply_chains.length == 0 ) {
                Dom.setStyle("incomingSupplyChainList", "display", "none");
    Severity: Major
    Found in app/js-yui/building.js - About 2 hrs to fix

      Function AddShipSummary has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              AddShipSummary : function(e, matchedEl, container){
                  var quantity = matchedEl.previousSibling.value*1,
                      li = matchedEl.parentNode,
                      c = Dom.get("tradeAddItems");
                  if(li && c) {
      Severity: Major
      Found in app/js-yui/building/tradeMinistry.js - About 2 hrs to fix

        Function _buildAttachmentPanel has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                _buildAttachmentPanel : _.once(function() {
                    var panelId = "attachmentPanel";
        
                    var panel = document.createElement("div");
                    panel.id = panelId;
        Severity: Major
        Found in app/js-yui/messaging.js - About 2 hrs to fix

          Function AddPlan has 52 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  AddPlan : function(e, matchedEl, container){
                      var quantity = matchedEl.previousSibling.value*1,
                          li = matchedEl.parentNode,
                          c = Dom.get("tradeAddItems");
                      if(li && c) {
          Severity: Major
          Found in app/js-yui/building/transporter.js - About 2 hrs to fix

            Function _getOrbitsHtml has 52 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            _getOrbitsHtml : function() {
                                 var data = this._serverOverview.orbits;
            
                                 return  ['<ul class="statsList">',
                                         '<li><label>Orbits</label><ul class="statsSubList">',
            Severity: Major
            Found in app/js-yui/stats.js - About 2 hrs to fix

              Function PushAddPlan has 52 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      PushAddPlan : function(e, matchedEl, container){
                          var quantity = matchedEl.previousSibling.value*1,
                              li = matchedEl.parentNode,
                              c = Dom.get("tradePushItems");
                          if(quantity && li && c) {
              Severity: Major
              Found in app/js-yui/building/transporter.js - About 2 hrs to fix

                Function PushAddPlanSummary has 52 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        PushAddPlanSummary : function(e, matchedEl, container){
                            var quantity = matchedEl.previousSibling.value*1,
                                li = matchedEl.parentNode,
                                c = Dom.get("tradePushItems");
                            if(quantity && li && c) {
                Severity: Major
                Found in app/js-yui/building/tradeMinistry.js - About 2 hrs to fix

                  Function AddPlanSummary has 52 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          AddPlanSummary : function(e, matchedEl, container){
                              var quantity = matchedEl.previousSibling.value*1,
                                  li = matchedEl.parentNode,
                                  c = Dom.get("tradeAddItems");
                              if(li && c) {
                  Severity: Major
                  Found in app/js-yui/building/tradeMinistry.js - About 2 hrs to fix

                    File bottomBar.jsx has 252 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    'use strict';
                    
                    var React                = require('react');
                    var ReactDOM             = require('react-dom');
                    var ReactDOMServer       = require('react-dom/server');
                    Severity: Minor
                    Found in app/js/components/menu/bottomBar.jsx - About 2 hrs to fix

                      Function _getPushTab has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      _getPushTab : function() {
                      this.push = new YAHOO.widget.Tab({ label: "Push", content: [
                          '<div id="pHt"><div class="tradeStash yui-g">',
                          '    <div class="yui-u first">',
                          '        <legend>On Planet</legend>',
                      Severity: Minor
                      Found in app/js-yui/building/tradeMinistry.js - About 2 hrs to fix

                        Function PopulateShipsSendTab has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                PopulateShipsSendTab : function(target, ships) {
                                    var details = Dom.get("sendShipAvail"),
                                        detailsParent = details.parentNode,
                                        li = document.createElement("li");
                        
                        
                        Severity: Minor
                        Found in app/js-yui/building/spacePort.js - About 2 hrs to fix

                          Function PopulateFleetSendTab has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  PopulateFleetSendTab : function(panel) {
                                      var ships = this.currentShips.available,
                                          details = Dom.get(panel.isStarPanel ? "starDetailSendFleet" : "planetDetailSendFleet"),
                                          btn = Dom.get(panel.isStarPanel ? "starDetailSendFleetSubmit" : "planetDetailSendFleetSubmit"),
                                          detailsParent = details.parentNode,
                          Severity: Minor
                          Found in app/js-yui/mapStar.js - About 2 hrs to fix

                            Function MoveSpies has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    MoveSpies : function(e, tab) {
                                        Event.stopEvent(e);
                                        var spies = [];
                                        var ships = tab.avail.spyShips;
                                        var list = tab.elSpyShipsList;
                            Severity: Minor
                            Found in app/js-yui/mapStar.js - About 2 hrs to fix

                              Function PopulateShipsSendTab has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      PopulateShipsSendTab : function(panel) {
                                          var ships = this.currentShips.available,
                                              details = Dom.get(panel.isStarPanel ? "starDetailSendShips" : "planetDetailSendShips"),
                                              detailsParent = details.parentNode,
                                              li = document.createElement("li");
                              Severity: Minor
                              Found in app/js-yui/mapStar.js - About 1 hr to fix

                                Function sendMessage has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                        sendMessage : function() {
                                            var to = this.createTo.Selections();
                                            if(to.length == 0) {
                                                this.createResponse.innerHTML = "Must send a message To someone.";
                                            }
                                Severity: Minor
                                Found in app/js-yui/messaging.js - About 1 hr to fix

                                  Function renderChat has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      renderChat : function() {
                                  
                                          // Only do this process once.
                                          // NOTE: it's checked before but we're just making sure. (nice rhyming)
                                          if (this.hasRenderedChat === true) {
                                  Severity: Minor
                                  Found in app/js/components/menu/chat.jsx - About 1 hr to fix

                                    Function AddResource has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                            AddResource : function(e, matchedEl, container){
                                                var quantity = matchedEl.previousSibling.value*1,
                                                    li = matchedEl.parentNode,
                                                    c = Dom.get("tradeAddItems");
                                                if(quantity && c) {
                                    Severity: Minor
                                    Found in app/js-yui/building/transporter.js - About 1 hr to fix

                                      Function PushAddResource has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                              PushAddResource : function(e, matchedEl, container){
                                                  var quantity = matchedEl.previousSibling.value*1,
                                                      li = matchedEl.parentNode,
                                                      c = Dom.get("tradePushItems");
                                                  if(quantity && c) {
                                      Severity: Minor
                                      Found in app/js-yui/building/transporter.js - About 1 hr to fix

                                        Function PushAddResource has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                                PushAddResource : function(e, matchedEl, container){
                                                    var quantity = matchedEl.previousSibling.value*1,
                                                        li = matchedEl.parentNode,
                                                        c = Dom.get("tradePushItems");
                                                    if(quantity && c) {
                                        Severity: Minor
                                        Found in app/js-yui/building/tradeMinistry.js - About 1 hr to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language