plattyp/sms_auth

View on GitHub

Showing 2 of 2 total issues

Method verify_user has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def verify_user
    verification = PhoneVerification.find_by_phone_number(phone_number)
    if verification_invalid?(verification)
      return verification_error(verification)
    end
Severity: Minor
Found in app/services/registration_service.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method register_user has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def register_user
    unless valid_phone_number?(phone_number)
      return [false, 'The phone number provided is not valid']
    end

Severity: Minor
Found in app/services/registration_service.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language