plexus/analects

View on GitHub

Showing 7 of 7 total issues

Method compat has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.compat(radical)
        { '⼀' => '一', '⼁' => '丨', '⼂' => '丶', '⼃' => '丿', '⼄' => '乙', '⼅' => '亅', '⼆' => '二',
          '⼇' => '亠', '⼈' => '人', '⼉' => '儿', '⼊' => '入', '⼋' => '八', '⼌' => '冂', '⼍' => '冖',
          '⼎' => '冫', '⼏' => '几', '⼐' => '凵', '⼑' => '刀', '⼒' => '力', '⼓' => '勹', '⼔' => '匕',
          '⼕' => '匚', '⼖' => '匸', '⼗' => '十', '⼘' => '卜', '⼙' => '卩', '⼚' => '厂', '⼛' => '厶',
Severity: Minor
Found in lib/analects/models/kangxi_radical.rb - About 1 hr to fix

    Method retrieve_unzip has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def retrieve_unzip(stream)
          require 'zip'
          location.mkdir unless location.exist?
          Zip::InputStream.open(stream) do |io|
            while (entry = io.get_next_entry)
    Severity: Minor
    Found in lib/analects/source.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method up has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def up
        path = ENV['CEDICT_PATH'] || Analects::CedictLoader::LOCAL
        unless File.exist? path
          puts '-- cedict file not found, downloading'
          Analects::CedictLoader.download!
    Severity: Minor
    Found in lib/generators/analects/cedict/templates/populate_cedict_table.rb - About 1 hr to fix

      Method data_dir has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def data_dir
            if options[:data_dir]
              Dir.mkdir(options[:data_dir]) unless File.exist?(options[:data_dir])
              return options[:data_dir]
            end
      Severity: Minor
      Found in lib/analects/library.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method each has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def each
            return to_enum(__method__) unless block_given?
            files.each do |file|
              file.each_line do |line|
                next unless matchdata = line.match(REGEXP)
      Severity: Minor
      Found in lib/analects/unihan_loader.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method each has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def each
            return to_enum(__method__) unless block_given?
            numize = ->(n) { Integer(n) rescue n }
            @location.each_line do |line|
              char, rest = line.strip.split(':')
      Severity: Minor
      Found in lib/analects/cjk_decomp_loader.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(io, _library)
            @contents = io.read
            @headers = {}
            @contents.each_line do |line|
              @headers[Regexp.last_match(1).strip] = Regexp.last_match(2).strip if line =~ /^#! (.*)=(.*)/
      Severity: Minor
      Found in lib/analects/cedict_loader.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language