pluf/workflow

View on GitHub

Showing 56 of 58 total issues

StateMachineImpl has 75 functions (exceeds 20 allowed). Consider refactoring.
Open

class StateMachineImpl implements StateMachine
{
    use AssertTrait;
    use EventHandlerTrait;

Severity: Major
Found in src/Imp/StateMachineImpl.php - About 1 day to fix

    File StateMachineImpl.php has 595 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    namespace Pluf\Workflow\Imp;
    
    use Pluf\Workflow\ActionExecutionService;
    use Pluf\Workflow\ErrorCodes;
    Severity: Major
    Found in src/Imp/StateMachineImpl.php - About 1 day to fix

      File StateMachineBuilderImpl.php has 584 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      namespace Pluf\Workflow\Imp;
      
      use Pluf\Di\Container;
      use Pluf\Workflow\Action;
      Severity: Major
      Found in src/Imp/StateMachineBuilderImpl.php - About 1 day to fix

        StateMachineBuilderImpl has 63 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class StateMachineBuilderImpl implements UntypedStateMachineBuilder, StateMachineBuilder
        {
            use AssertTrait;
        
            // static {
        Severity: Major
        Found in src/Imp/StateMachineBuilderImpl.php - About 1 day to fix

          File StateImpl.php has 485 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          namespace Pluf\Workflow\Imp;
          
          use Pluf\Workflow\HistoryType;
          use Pluf\Workflow\ImmutableState;
          Severity: Minor
          Found in src/Imp/StateImpl.php - About 7 hrs to fix

            Function internalFire has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
            Open

                public function internalFire($stateContext): void
                {
                    $currentTransitionResult = $stateContext->getResult();
                    if ($this->isParallelState()) {
                        /*
            Severity: Minor
            Found in src/Imp/StateImpl.php - About 7 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            StateImpl has 50 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class StateImpl implements MutableState
            {
            
                // private static final Logger logger = LoggerFactory.getLogger(StateImpl.class);
                protected $stateId;
            Severity: Minor
            Found in src/Imp/StateImpl.php - About 7 hrs to fix

              StateMachineDataImpl has 42 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class StateMachineDataImpl implements StateMachineData, StateMachineDataReader, StateMachineDataWriter
              {
                  use AssertTrait;
              
                  // private static final Logger logger = LoggerFactory.getLogger(StateMachineDataImpl.class);
              Severity: Minor
              Found in src/Imp/StateMachineDataImpl.php - About 5 hrs to fix

                Function exit has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function exit(StateContext $stateContext): void
                    {
                        if ($this->isParallelState()) {
                            $subStates = $this->getSubStatesOn($this, $stateContext->getStateMachineData()
                                ->read());
                Severity: Minor
                Found in src/Imp/StateImpl.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function doTransitInternal has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function doTransitInternal(ImmutableState $source, ImmutableState $target, StateContext $stateContext): void
                    {
                        if ($source == $this->getTargetState()) {
                            // Handles 1.
                            // Handles 3. after traversing from the source to the target.
                Severity: Minor
                Found in src/Imp/TransitionImpl.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function buildDeclareTransition has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function buildDeclareTransition(Transit $transit): void
                    {
                        if (empty($transit)) {
                            return;
                        }
                Severity: Minor
                Found in src/Imp/StateMachineBuilderImpl.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                TransitionImpl has 25 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class TransitionImpl implements MutableTransition
                {
                
                    public ImmutableState $sourceState;
                
                
                Severity: Minor
                Found in src/Imp/TransitionImpl.php - About 2 hrs to fix

                  Method internalFire has 62 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function internalFire($stateContext): void
                      {
                          $currentTransitionResult = $stateContext->getResult();
                          if ($this->isParallelState()) {
                              /*
                  Severity: Major
                  Found in src/Imp/StateImpl.php - About 2 hrs to fix

                    Method buildDeclareTransition has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private function buildDeclareTransition(Transit $transit): void
                        {
                            if (empty($transit)) {
                                return;
                            }
                    Severity: Major
                    Found in src/Imp/StateMachineBuilderImpl.php - About 2 hrs to fix

                      Function checkConflictTransitions has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function checkConflictTransitions(ImmutableTransition $target, array $allTransitions): ?ImmutableTransition
                          {
                              foreach ($allTransitions as $t) {
                                  if ($target == $t || $t->getCondition()::class == Never::class/* Conditions::Never::class */) {
                                      continue;
                      Severity: Minor
                      Found in src/Imp/StateImpl.php - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method exit has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function exit(StateContext $stateContext): void
                          {
                              if ($this->isParallelState()) {
                                  $subStates = $this->getSubStatesOn($this, $stateContext->getStateMachineData()
                                      ->read());
                      Severity: Minor
                      Found in src/Imp/StateImpl.php - About 1 hr to fix

                        Method processEvent has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private function processEvent($event, $context, StateMachineData $originalData, ExecutionServiceImpl $executionService, bool $DataIsolateEnabled): bool
                            {
                                $localData = $originalData;
                                $fromState = $localData->read()->getCurrentRawState();
                                $fromStateId = $fromState->getStateId();
                        Severity: Minor
                        Found in src/Imp/StateMachineImpl.php - About 1 hr to fix

                          Function installExtensionMethods has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                          Open

                              private function installExtensionMethods(): void
                              {
                                  foreach ($this->states as $state) {
                                      // Ignore all the transition start from a final state
                                      if ($state->isFinalState()) {
                          Severity: Minor
                          Found in src/Imp/StateMachineBuilderImpl.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function doExecute has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                          Open

                              private function doExecute(string $bucketName, array $bucketActions): void
                              {
                                  // TODO: make a contaner and invoker
                                  // TODO: reset most be supported
                                  // $this->assertNotEmpty($bucketActions, "Action bucket cannot be empty when executing.");
                          Severity: Minor
                          Found in src/Imp/ExecutionServiceImpl.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              public function __construct(?string $parent = null, ?string $name = null, ?string $alias = null, ?string $entryCallMethod = null, ?string $exitCallMethod = null, bool $initialState = false, bool $finalState = false, string $historyType = HistoryType::NONE, string $compositeType = StateCompositeType::SEQUENTIAL)
                          Severity: Major
                          Found in src/Attributes/State.php - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language