Sign upLogin

pluswerk/mail_logger

View on GitHub
Star

Showing 6 of 10 total issues

MailTemplate has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class MailTemplate extends AbstractModel
{
    protected string $typoScriptKey = '';

    protected string $templatePathKey = '';
Severity: Minor
Found in Classes/Domain/Model/MailTemplate.php - About 2 hrs to fix

    TemplateBasedMailMessage has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class TemplateBasedMailMessage extends MailMessage
{
    protected MailTemplate $mailTemplate;

    /**
    Severity: Minor
    Found in Classes/Domain/Model/TemplateBasedMailMessage.php - About 2 hrs to fix

      Method assignMailTemplateValues has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function assignMailTemplateValues(array $values): void
    {
        if (!empty($values['typoScriptKey'])) {
            $this->assignDefaultsFromTypoScript($values['typoScriptKey'], $this->mailTemplate->getTemplatePathKey());
        }
      Severity: Minor
      Found in Classes/Domain/Model/TemplateBasedMailMessage.php - About 1 hr to fix

        Function showMailLogModal has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function showMailLogModal(html, title) {
    const typo3Window = (opener != null && typeof opener.top.TYPO3 !== 'undefined' ? opener.top : top);
    const buttonClass = Severity.getCssClass(Severity.info);

    const buttons = [{
        Severity: Minor
        Found in Resources/Public/JavaScript/MailLogModal.js - About 1 hr to fix

          Function assignMailTemplateValues has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              private function assignMailTemplateValues(array $values): void
    {
        if (!empty($values['typoScriptKey'])) {
            $this->assignDefaultsFromTypoScript($values['typoScriptKey'], $this->mailTemplate->getTemplatePathKey());
        }
          Severity: Minor
          Found in Classes/Domain/Model/TemplateBasedMailMessage.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getBodyAsHtml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function getBodyAsHtml(AbstractPart $part): string
    {
        if ($part instanceof AbstractMultipartPart) {
            $messageString = '';
            foreach ($part->getParts() as $childPart) {
          Severity: Minor
          Found in Classes/Logging/LoggingTransport.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language