poise/application

View on GitHub

Showing 2 of 2 total issues

Method register_subresource has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        def register_subresource(resource)
          super.tap do |added|
            if added && action_on_update
              Chef::Log.debug("[#{self}] Registering #{action_on_update_immediately ? 'immediate ' : ''}#{action_on_update} notification from #{resource}")
              resource.notifies action_on_update.to_sym, self, (action_on_update_immediately ? :immediately : :delayed)
Severity: Minor
Found in lib/poise_application/resources/application.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _rewire_resources has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        def _rewire_resources
          if defined?(Chef::DSL::Resources)
            # Chef >= 12.4.
            Chef::DSL::Resources.instance_methods
          else
Severity: Minor
Found in lib/poise_application/resources/application.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language