Sign upLogin

polypoly-team/android-app

View on GitHub
Star

Showing 28 of 43 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                Text(
                    text = "Background location permission was denied, the game will continue with taxing disabled.",
                    fontWeight = FontWeight.Bold,
                    modifier = Modifier
                        .align(Alignment.Center)
Severity: Minor
Found in app/src/main/java/com/github/polypoly/app/ui/game/GameActivity.kt and 1 other location - About 55 mins to fix
app/src/main/java/com/github/polypoly/app/ui/game/GameActivity.kt on lines 195..201

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    Text(
                        text = "Background location permission is required to passively tax players if they are in a location property that is owned by another player.",
                        fontWeight = FontWeight.Bold,
                        modifier = Modifier
                            .align(Alignment.Center)
Severity: Minor
Found in app/src/main/java/com/github/polypoly/app/ui/game/GameActivity.kt and 1 other location - About 55 mins to fix
app/src/main/java/com/github/polypoly/app/ui/game/GameActivity.kt on lines 224..230

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    /**
     * Retrieves all values associated to a given [StorableObject] subclass
     * @param clazz: corresponding [StorableObject] subclass
     * @return A future with the keys found (empty is no key was found)
     */
Severity: Minor
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 1 other location - About 55 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 38..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    /**
     * Retrieves all values associated to a given [StorableObject] subclass
     * @param clazz: corresponding [StorableObject] subclass
     * @return A future with the values found (empty is no value was found)
     */
Severity: Minor
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 1 other location - About 55 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 45..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    /**
     * Removes the element with the given key, this should also remove any listeners associated to it
     * @param key: key of the value to delete
     * @param clazz: corresponding [StorableObject] subclass
     * @return A future holding true if a value was successfully removed, false if no value existed
Severity: Major
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 4 other locations - About 50 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 18..26
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 52..58
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 128..133
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 141..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    /**
     * Same as [deleteOnChangeListener] with key parameter but this will delete the listener
     * listening to the root of the correspondingStorableObject subclass with the given [tag]
     */
    fun <T : StorableObject<*>> deleteOnRootChangeListener(tag: String, clazz: KClass<T>): CompletableFuture<Boolean>
Severity: Major
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 4 other locations - About 50 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 18..26
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 52..58
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 90..96
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 128..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    /**
     * Retrieves the [T] instance associated to the given key
     * @param key: key of the value asked
     * @param clazz: corresponding [StorableObject] subclass
     * @return A future with the value found
Severity: Major
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 4 other locations - About 50 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 52..58
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 90..96
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 128..133
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 141..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    /**
     * Checks if an object of class [T] with the given key exists within the storage
     * @param key: key to check
     * @param clazz: corresponding [StorableObject] subclass
     * @return A future holding true iff the key exists
Severity: Major
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 4 other locations - About 50 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 18..26
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 90..96
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 128..133
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 141..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    /**
     * Removes (if any) all the listeners attached to the data corresponding to the given key
     * @param key: key of the data to stop listening
     * @param clazz: corresponding [StorableObject] subclass
     */
Severity: Major
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 4 other locations - About 50 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 18..26
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 52..58
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 90..96
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 141..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                BigButton(onClick = {
                    val joinGroupIntent = Intent(mContext, JoinGameLobbyActivity::class.java)
                    startActivity(joinGroupIntent)
                }, text = "Join Game!")
Severity: Minor
Found in app/src/main/java/com/github/polypoly/app/ui/menu/WelcomeActivity.kt and 1 other location - About 50 mins to fix
app/src/main/java/com/github/polypoly/app/ui/menu/WelcomeActivity.kt on lines 113..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                BigButton(onClick = {
                    val createGameLobbyIntent = Intent(mContext, CreateGameLobbyActivity::class.java)
                    startActivity(createGameLobbyIntent)
                }, text = "Create Game?")
Severity: Minor
Found in app/src/main/java/com/github/polypoly/app/ui/menu/WelcomeActivity.kt and 1 other location - About 50 mins to fix
app/src/main/java/com/github/polypoly/app/ui/menu/WelcomeActivity.kt on lines 107..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    override fun <T : StorableObject<*>> addOnRootChangeListener(
        tag: String,
        action: (newObjects: List<T>) -> Unit,
        clazz: KClass<T>
    ): CompletableFuture<Boolean> {
Severity: Minor
Found in app/src/main/java/com/github/polypoly/app/database/RemoteDB.kt and 1 other location - About 45 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 139..139

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    fun <T : StorableObject<*>> addOnRootChangeListener(tag: String, action: (newObjects: List<T>) -> Unit, clazz: KClass<T>): CompletableFuture<Boolean>
Severity: Minor
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 1 other location - About 45 mins to fix
app/src/main/java/com/github/polypoly/app/database/RemoteDB.kt on lines 246..250

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    fun <T : StorableObject<*>> addOnChangeListener(key: String, tag: String, action: (newObj: T) -> Unit, clazz: KClass<T>): CompletableFuture<Boolean>
Severity: Minor
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 1 other location - About 45 mins to fix
app/src/main/java/com/github/polypoly/app/database/RemoteDB.kt on lines 190..195

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    override fun <T : StorableObject<*>> addOnChangeListener(
        key: String,
        tag: String,
        action: (newObj: T) -> Unit,
        clazz: KClass<T>
Severity: Minor
Found in app/src/main/java/com/github/polypoly/app/database/RemoteDB.kt and 1 other location - About 45 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 115..115

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

inline fun <reified T : StorableObject<*>> IRemoteStorage.keyExists(key: String) = keyExists(key, T::class)
Severity: Major
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 4 other locations - About 45 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 157..161
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 167..168
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 173..173
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 175..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

/**
 * Extension functions of IRemoteStorage to enable prettier call of the functions
 */
// GETTERS
inline fun <reified T : StorableObject<*>> IRemoteStorage.getValue(key: String) = getValue(key, T::class)
Severity: Major
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 4 other locations - About 45 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 165..165
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 167..168
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 173..173
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 175..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

inline fun <reified T : StorableObject<*>> IRemoteStorage.deleteOnRootChangeListener(tag: String) = deleteOnRootChangeListener(tag, T::class)
Severity: Major
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 4 other locations - About 45 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 157..161
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 165..165
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 167..168
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 173..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

// SETTERS
inline fun <reified T : StorableObject<*>> IRemoteStorage.removeValue(key: String) = removeValue(key, T::class)
Severity: Major
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 4 other locations - About 45 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 157..161
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 165..165
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 173..173
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 175..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

inline fun <reified T : StorableObject<*>> IRemoteStorage.deleteAllOnChangeListeners(key: String) = deleteAllOnChangeListeners(key, T::class)
Severity: Major
Found in app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt and 4 other locations - About 45 mins to fix
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 157..161
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 165..165
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 167..168
app/src/main/java/com/github/polypoly/app/database/IRemoteStorage.kt on lines 175..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language