portainer/portainer

View on GitHub
app/docker/views/containers/edit/containerController.js

Summary

Maintainability
D
1 day
Test Coverage

File containerController.js has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import moment from 'moment';
import _ from 'lodash-es';
import { PorImageRegistryModel } from 'Docker/models/porImageRegistry';
import { confirmContainerDeletion } from '@/react/docker/containers/common/confirm-container-delete-modal';
import { FeatureId } from '@/react/portainer/feature-flags/enums';
Severity: Minor
Found in app/docker/views/containers/edit/containerController.js - About 3 hrs to fix

    Function update has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var update = function () {
          var nodeName = $transition$.params().nodeName;
          HttpRequestHelper.setPortainerAgentTargetHeader(nodeName);
          $scope.nodeName = nodeName;
    
    
    Severity: Major
    Found in app/docker/views/containers/edit/containerController.js - About 2 hrs to fix

      Function success has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              .then(function success(data) {
                var container = data;
                $scope.container = container;
                $scope.container.edit = false;
                $scope.container.newContainerName = $filter('trimcontainername')(container.Name);
      Severity: Minor
      Found in app/docker/views/containers/edit/containerController.js - About 1 hr to fix

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            $scope.start = function () {
              var successMessage = 'Container successfully started';
              var errorMessage = 'Unable to start container';
              executeContainerAction($transition$.params().id, ContainerService.startContainer, successMessage, errorMessage);
            };
        Severity: Major
        Found in app/docker/views/containers/edit/containerController.js and 5 other locations - About 1 hr to fix
        app/docker/views/containers/edit/containerController.js on lines 177..181
        app/docker/views/containers/edit/containerController.js on lines 183..187
        app/docker/views/containers/edit/containerController.js on lines 189..193
        app/docker/views/containers/edit/containerController.js on lines 195..199
        app/docker/views/containers/edit/containerController.js on lines 201..205

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            $scope.kill = function () {
              var successMessage = 'Container successfully killed';
              var errorMessage = 'Unable to kill container';
              executeContainerAction($transition$.params().id, ContainerService.killContainer, successMessage, errorMessage);
            };
        Severity: Major
        Found in app/docker/views/containers/edit/containerController.js and 5 other locations - About 1 hr to fix
        app/docker/views/containers/edit/containerController.js on lines 171..175
        app/docker/views/containers/edit/containerController.js on lines 177..181
        app/docker/views/containers/edit/containerController.js on lines 189..193
        app/docker/views/containers/edit/containerController.js on lines 195..199
        app/docker/views/containers/edit/containerController.js on lines 201..205

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            $scope.pause = function () {
              var successMessage = 'Container successfully paused';
              var errorMessage = 'Unable to pause container';
              executeContainerAction($transition$.params().id, ContainerService.pauseContainer, successMessage, errorMessage);
            };
        Severity: Major
        Found in app/docker/views/containers/edit/containerController.js and 5 other locations - About 1 hr to fix
        app/docker/views/containers/edit/containerController.js on lines 171..175
        app/docker/views/containers/edit/containerController.js on lines 177..181
        app/docker/views/containers/edit/containerController.js on lines 183..187
        app/docker/views/containers/edit/containerController.js on lines 195..199
        app/docker/views/containers/edit/containerController.js on lines 201..205

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            $scope.stop = function () {
              var successMessage = 'Container successfully stopped';
              var errorMessage = 'Unable to stop container';
              executeContainerAction($transition$.params().id, ContainerService.stopContainer, successMessage, errorMessage);
            };
        Severity: Major
        Found in app/docker/views/containers/edit/containerController.js and 5 other locations - About 1 hr to fix
        app/docker/views/containers/edit/containerController.js on lines 171..175
        app/docker/views/containers/edit/containerController.js on lines 183..187
        app/docker/views/containers/edit/containerController.js on lines 189..193
        app/docker/views/containers/edit/containerController.js on lines 195..199
        app/docker/views/containers/edit/containerController.js on lines 201..205

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            $scope.restart = function () {
              var successMessage = 'Container successfully restarted';
              var errorMessage = 'Unable to restart container';
              executeContainerAction($transition$.params().id, ContainerService.restartContainer, successMessage, errorMessage);
            };
        Severity: Major
        Found in app/docker/views/containers/edit/containerController.js and 5 other locations - About 1 hr to fix
        app/docker/views/containers/edit/containerController.js on lines 171..175
        app/docker/views/containers/edit/containerController.js on lines 177..181
        app/docker/views/containers/edit/containerController.js on lines 183..187
        app/docker/views/containers/edit/containerController.js on lines 189..193
        app/docker/views/containers/edit/containerController.js on lines 195..199

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            $scope.unpause = function () {
              var successMessage = 'Container successfully resumed';
              var errorMessage = 'Unable to resume container';
              executeContainerAction($transition$.params().id, ContainerService.resumeContainer, successMessage, errorMessage);
            };
        Severity: Major
        Found in app/docker/views/containers/edit/containerController.js and 5 other locations - About 1 hr to fix
        app/docker/views/containers/edit/containerController.js on lines 171..175
        app/docker/views/containers/edit/containerController.js on lines 177..181
        app/docker/views/containers/edit/containerController.js on lines 183..187
        app/docker/views/containers/edit/containerController.js on lines 189..193
        app/docker/views/containers/edit/containerController.js on lines 201..205

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status