portainer/portainer

View on GitHub
app/kubernetes/views/resource-pools/edit/resourcePoolController.js

Summary

Maintainability
D
2 days
Test Coverage

File resourcePoolController.js has 342 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import angular from 'angular';
import _ from 'lodash-es';
import filesizeParser from 'filesize-parser';
import { KubernetesResourceQuotaDefaults } from 'Kubernetes/models/resource-quota/models';
import KubernetesResourceReservationHelper from 'Kubernetes/helpers/resourceReservationHelper';
Severity: Minor
Found in app/kubernetes/views/resource-pools/edit/resourcePoolController.js - About 4 hrs to fix

    KubernetesResourcePoolController has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class KubernetesResourcePoolController {
      /* #region  CONSTRUCTOR */
      /* @ngInject */
      constructor(
        $async,
    Severity: Minor
    Found in app/kubernetes/views/resource-pools/edit/resourcePoolController.js - About 2 hrs to fix

      Function $onInit has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        $onInit() {
          return this.$async(async () => {
            try {
              this.endpoint = await this.EndpointService.endpoint(this.endpoint.Id);
              this.isAdmin = this.Authentication.isAdmin();
      Severity: Major
      Found in app/kubernetes/views/resource-pools/edit/resourcePoolController.js - About 2 hrs to fix

        Function constructor has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          constructor(
            $async,
            $state,
            $scope,
            Authentication,
        Severity: Minor
        Found in app/kubernetes/views/resource-pools/edit/resourcePoolController.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            isQuotaValid() {
              if (
                this.state.sliderMaxCpu < this.formValues.CpuLimit ||
                this.state.sliderMaxMemory < this.formValues.MemoryLimit ||
                (this.formValues.CpuLimit === 0 && this.formValues.MemoryLimit === 0)
          app/kubernetes/views/resource-pools/create/createResourcePoolController.js on lines 87..96

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 97.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            onToggleStorageQuota(storageClassName, enabled) {
              this.$scope.$evalAsync(() => {
                this.formValues.StorageClasses = this.formValues.StorageClasses.map((sClass) => (sClass.Name !== storageClassName ? sClass : { ...sClass, Selected: enabled }));
              });
            }
          app/kubernetes/views/resource-pools/create/createResourcePoolController.js on lines 48..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                const namespaceResourceUsage = containerResourceUsageList.reduce((total, u) => {
                  total.CPU += KubernetesResourceReservationHelper.parseCPU(u.cpu);
                  total.Memory += KubernetesResourceReservationHelper.megaBytesValue(u.memory);
                  return total;
                }, new KubernetesResourceReservation());
          app/kubernetes/views/cluster/clusterController.js on lines 104..108

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  _.forEach(nodes, (item) => {
                    this.state.sliderMaxMemory += filesizeParser(item.Memory);
                    this.state.sliderMaxCpu += item.CPU;
                  });
          app/kubernetes/views/resource-pools/create/createResourcePoolController.js on lines 208..211

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            onRegistriesChange(registries) {
              return this.$scope.$evalAsync(() => {
                this.formValues.Registries = registries;
              });
            }
          app/kubernetes/views/resource-pools/create/createResourcePoolController.js on lines 42..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status