Sign upLogin

portainer/portainer

View on GitHub
Star
app/portainer/services/api/stackService.js

Summary

Maintainability
F
5 days
Test Coverage

Function StackServiceFactory has 400 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function StackServiceFactory($q, $async, Stack, StackByName, FileUploadService, StackHelper, ServiceService, ContainerService, SwarmService) {
    'use strict';
    var service = {
      updateGit,
      updateKubeGit,
Severity: Major
Found in app/portainer/services/api/stackService.js - About 2 days to fix

    Function StackServiceFactory has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

      function StackServiceFactory($q, $async, Stack, StackByName, FileUploadService, StackHelper, ServiceService, ContainerService, SwarmService) {
    'use strict';
    var service = {
      updateGit,
      updateKubeGit,
    Severity: Minor
    Found in app/portainer/services/api/stackService.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File stackService.js has 417 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import _ from 'lodash-es';
import { transformAutoUpdateViewModel } from '@/react/portainer/gitops/AutoUpdateFieldset/utils';
import { StackViewModel } from '@/react/docker/stacks/view-models/stack';

angular.module('portainer.app').factory('StackService', [
    Severity: Minor
    Found in app/portainer/services/api/stackService.js - About 6 hrs to fix

      Function createSwarmStackFromGitRepository has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          service.createSwarmStackFromGitRepository = function (name, repositoryOptions, env, endpointId) {
      var deferred = $q.defer();

      SwarmService.swarm()
        .then(function success(data) {
      Severity: Minor
      Found in app/portainer/services/api/stackService.js - About 1 hr to fix

        Function updateGit has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            function updateGit(id, endpointId, env, prune, gitConfig, pullImage) {
        Severity: Minor
        Found in app/portainer/services/api/stackService.js - About 45 mins to fix

          Function duplicateStack has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              service.duplicateStack = function duplicateStack(name, stackFileContent, env, endpointId, type) {
          Severity: Minor
          Found in app/portainer/services/api/stackService.js - About 35 mins to fix

            Function updateStack has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                service.updateStack = function (stack, stackFile, env, prune, pullImage) {
            Severity: Minor
            Found in app/portainer/services/api/stackService.js - About 35 mins to fix

              Function updateGitStackSettings has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  service.updateGitStackSettings = function (id, endpointId, env, gitConfig, webhookId) {
              Severity: Minor
              Found in app/portainer/services/api/stackService.js - About 35 mins to fix

                Similar blocks of code found in 8 locations. Consider refactoring.
                Open

                    service.stack = function (id) {
      var deferred = $q.defer();

      Stack.get({ id: id })
        .$promise.then(function success(data) {
                Severity: Major
                Found in app/portainer/services/api/stackService.js and 7 other locations - About 5 hrs to fix
                app/docker/services/networkService.js on lines 23..36
                app/docker/services/secretService.js on lines 10..23
                app/docker/services/serviceService.js on lines 28..41
                app/docker/services/taskService.js on lines 11..24
                app/docker/services/volumeService.js on lines 27..38
                app/portainer/services/api/groupService.js on lines 10..23
                app/portainer/services/api/teamService.js on lines 26..37

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 135.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      SwarmService.swarm()
        .then(function success(data) {
          var swarm = data;
          filters = { SwarmID: swarm.Id, ...filters };
                Severity: Major
                Found in app/portainer/services/api/stackService.js and 1 other location - About 2 hrs to fix
                app/portainer/services/api/stackService.js on lines 162..174

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 89.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      $q.all({
        stacks: Stack.query({ filters: filters }).$promise,
        externalStacks: includeExternalStacks ? service.externalComposeStacks(endpointId) : [],
      })
        .then(function success(data) {
                Severity: Major
                Found in app/portainer/services/api/stackService.js and 1 other location - About 2 hrs to fix
                app/portainer/services/api/stackService.js on lines 185..203

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 89.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status