Sign upLogin

portainer/portainer

View on GitHub
Star
app/portainer/views/endpoints/edit/endpointController.js

Summary

Maintainability
F
4 days
Test Coverage

Function EndpointController has 292 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function EndpointController(
  $async,
  $scope,
  $state,
  $transition$,
Severity: Major
Found in app/portainer/views/endpoints/edit/endpointController.js - About 1 day to fix

    Function EndpointController has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
    Open

    function EndpointController(
  $async,
  $scope,
  $state,
  $transition$,
    Severity: Minor
    Found in app/portainer/views/endpoints/edit/endpointController.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File endpointController.js has 318 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import _ from 'lodash-es';
import uuidv4 from 'uuid/v4';

import { PortainerEndpointTypes } from '@/portainer/models/endpoint/models';
import EndpointHelper from '@/portainer/helpers/endpointHelper';
    Severity: Minor
    Found in app/portainer/views/endpoints/edit/endpointController.js - About 3 hrs to fix

      Function updateEndpoint has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        $scope.updateEndpoint = async function () {
    var endpoint = $scope.endpoint;

    if (isEdgeEnvironment(endpoint.Type) && _.difference($scope.initialTagIds, endpoint.TagIds).length > 0) {
      let confirmed = await confirmDestructive({
      Severity: Major
      Found in app/portainer/views/endpoints/edit/endpointController.js - About 2 hrs to fix

        Function initView has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async function initView() {
    return $async(async () => {
      try {
        const [endpoint, groups, settings] = await Promise.all([EndpointService.endpoint($transition$.params().id), GroupService.groups(), SettingsService.settings()]);
        Severity: Major
        Found in app/portainer/views/endpoints/edit/endpointController.js - About 2 hrs to fix

          Function EndpointController has 11 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            $async,
  $scope,
  $state,
  $transition$,
  $filter,
          Severity: Major
          Found in app/portainer/views/endpoints/edit/endpointController.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  $scope.endpoint.Type === PortainerEndpointTypes.KubernetesLocalEnvironment ||
      $scope.endpoint.Type === PortainerEndpointTypes.AgentOnKubernetesEnvironment ||
      $scope.endpoint.Type === PortainerEndpointTypes.EdgeAgentOnKubernetesEnvironment
            Severity: Major
            Found in app/portainer/views/endpoints/edit/endpointController.js and 1 other location - About 1 hr to fix
            app/portainer/views/endpoints/edit/endpointController.js on lines 277..279

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  $scope.endpoint.Type === PortainerEndpointTypes.AgentOnDockerEnvironment ||
      $scope.endpoint.Type === PortainerEndpointTypes.EdgeAgentOnDockerEnvironment ||
      $scope.endpoint.Type === PortainerEndpointTypes.AgentOnKubernetesEnvironment ||
            Severity: Major
            Found in app/portainer/views/endpoints/edit/endpointController.js and 1 other location - About 1 hr to fix
            app/portainer/views/endpoints/edit/endpointController.js on lines 264..266

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status