Sign upLogin

portrino/svconnector_csv_extended

View on GitHub
Star

Showing 14 of 14 total issues

Function synchronizeAllTables has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    public function synchronizeAllTables()
    {
        $allMessages = [];
        $externalTables = [];
Severity: Minor
Found in Classes/Importer.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getProgressForAllTables has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    public function getProgressForAllTables()
    {
        $result = false;
        // Look in the TCA for tables with an "external" control section and a "connector"
        // Tables without connectors cannot be synchronised
Severity: Minor
Found in Classes/Importer.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fetchData has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    public function fetchData(
        $parameters,
        $delimiter,
        $qualifier,
        $isSameCharset,
Severity: Minor
Found in Classes/Service/CycledDataFetcher.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getHeaders has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function getHeaders($parameters, $charset = 'utf8')
    {
        $headers = [];
        $filename = $this->getFileNameOfCsvFile($parameters);
        if ($this->fileIsExisting($filename)) {
Severity: Minor
Found in Classes/Service/CycleService.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method synchronizeAllTables has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function synchronizeAllTables()
    {
        $allMessages = [];
        $externalTables = [];
Severity: Major
Found in Classes/Importer.php - About 2 hrs to fix

    Function query has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function query($parameters)
    {
        $fileData = [];
        // Check if the file is defined and exists
        if (empty($parameters['filename'])) {
    Severity: Minor
    Found in Classes/Service/ConnectorCsvExtended.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getProgress has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getProgress()
    {
        $result = 100.00;

        /** @var Importer $importer */
    Severity: Minor
    Found in Classes/Task/AutomatedSyncTaskWithProgress.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method query has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function query($parameters)
    {
        $fileData = [];
        // Check if the file is defined and exists
        if (empty($parameters['filename'])) {
    Severity: Major
    Found in Classes/Service/ConnectorCsvExtended.php - About 2 hrs to fix

      Method fetchData has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function fetchData(
        $parameters,
        $delimiter,
        $qualifier,
        $isSameCharset,
      Severity: Minor
      Found in Classes/Service/CycledDataFetcher.php - About 2 hrs to fix

        Method getProgressForAllTables has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getProgressForAllTables()
    {
        $result = false;
        // Look in the TCA for tables with an "external" control section and a "connector"
        // Tables without connectors cannot be synchronised
        Severity: Minor
        Found in Classes/Importer.php - About 1 hr to fix

          Method getHeaders has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getHeaders($parameters, $charset = 'utf8')
    {
        $headers = [];
        $filename = $this->getFileNameOfCsvFile($parameters);
        if ($this->fileIsExisting($filename)) {
          Severity: Minor
          Found in Classes/Service/CycleService.php - About 1 hr to fix

            Method getProgress has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getProgress()
    {
        $result = 100.00;

        /** @var Importer $importer */
            Severity: Minor
            Found in Classes/Task/AutomatedSyncTaskWithProgress.php - About 1 hr to fix

              Method fetchData has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      $parameters,
        $delimiter,
        $qualifier,
        $isSameCharset,
        $encoding,
              Severity: Minor
              Found in Classes/Service/CycledDataFetcher.php - About 45 mins to fix

                Function getCycleInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getCycleInfo($parameters)
    {
        $result = null;
        if ($this->hasCycleBehaviour($parameters)) {
            $filename = $this->getFileNameOfCsvFile($parameters);
                Severity: Minor
                Found in Classes/Service/CycleService.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language