Showing 17 of 19 total issues
File command.rb has 370 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'command_mapper/command'
module Nmap
#
# ## Nmap options:Class Host has 33 methods (exceeds 20 allowed). Consider refactoring. Open
class Host
include Enumerable
#Class XML has 26 methods (exceeds 20 allowed). Consider refactoring. Open
class XML
include Enumerable
# The parsed XML document.Method validate has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
def validate(value)
case value
when Hash
if value.empty?
return [false, "Hash value cannot be empty"]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def validate(value)
case value
when Hash
if value.empty?
return [false, "cannot be empty"]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def validate(value)
case value
when Hash
if value.empty?
return [false, "Hash value cannot be empty"]Method validate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def validate(value)
case value
when Range
valid, message = super(value.begin)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def validate(value)
case value
when Integer then true
else
valid, message = super(value)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return [false, "not a valid port range list (#{value.inspect})"]Avoid too many return statements within this method. Open
return [false, "must be a valid port number, port range, or service name (#{value.inspect})"]Avoid too many return statements within this method. Open
return [false, "must only contain URG, ACK, PSH, RST, SYN, or FIN"]Avoid too many return statements within this method. Open
return trueAvoid too many return statements within this method. Open
return [false, "Array must only contain the values :urg, :ack, :psh, :rst, :syn, or :fin"]Avoid too many return statements within this method. Open
return trueAvoid too many return statements within this method. Open
return [valid, message]Avoid too many return statements within this method. Open
return [false, "Array value cannot be empty"]Avoid too many return statements within this method. Open
return true