Sign upLogin

prebid/Prebid.js

View on GitHub
Star
libraries/precisoUtils/bidUtilsCommon.js

Summary

Maintainability
D
2 days
Test Coverage

Function buildUserSyncs has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

export const buildUserSyncs = (syncOptions, serverResponses, gdprConsent, uspConsent, syncEndpoint) => {
  let syncType = syncOptions.iframeEnabled ? 'iframe' : 'image';
  const isCk2trk = syncEndpoint.includes('ck.2trk.info');

  // Base sync URL
Severity: Minor
Found in libraries/precisoUtils/bidUtilsCommon.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildBidRequests has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const buildBidRequests = (adurl) => (validBidRequests = [], bidderRequest) => {
  const winTop = getWindowTop();
  const location = winTop.location;
  const placements = [];
Severity: Minor
Found in libraries/precisoUtils/bidUtilsCommon.js - About 1 hr to fix

    Function buildBidRequests has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    export const buildBidRequests = (adurl) => (validBidRequests = [], bidderRequest) => {
  const winTop = getWindowTop();
  const location = winTop.location;
  const placements = [];
    Severity: Minor
    Found in libraries/precisoUtils/bidUtilsCommon.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function buildUserSyncs has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const buildUserSyncs = (syncOptions, serverResponses, gdprConsent, uspConsent, syncEndpoint) => {
  let syncType = syncOptions.iframeEnabled ? 'iframe' : 'image';
  const isCk2trk = syncEndpoint.includes('ck.2trk.info');

  // Base sync URL
    Severity: Minor
    Found in libraries/precisoUtils/bidUtilsCommon.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

        if (!bid.requestId || !bid.cpm || !bid.creativeId ||
        !bid.ttl || !bid.currency || !bid.meta) {
    return false;
  }
      Severity: Major
      Found in libraries/precisoUtils/bidUtilsCommon.js - About 40 mins to fix

        Function consentCheck has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export function consentCheck(bidderRequest, req) {
  if (bidderRequest) {
    if (bidderRequest.uspConsent) {
      req.ccpa = bidderRequest.uspConsent;
    }
        Severity: Minor
        Found in libraries/precisoUtils/bidUtilsCommon.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function isBidResponseValid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function isBidResponseValid(bid) {
  if (!bid.requestId || !bid.cpm || !bid.creativeId ||
        !bid.ttl || !bid.currency || !bid.meta) {
    return false;
  }
        Severity: Minor
        Found in libraries/precisoUtils/bidUtilsCommon.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function interpretResponse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export function interpretResponse(serverResponse) {
  let response = [];
  for (let i = 0; i < serverResponse.body.length; i++) {
    let resItem = serverResponse.body[i];
    if (isBidResponseValid(resItem)) {
        Severity: Minor
        Found in libraries/precisoUtils/bidUtilsCommon.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        export function interpretResponse(serverResponse) {
  let response = [];
  for (let i = 0; i < serverResponse.body.length; i++) {
    let resItem = serverResponse.body[i];
    if (isBidResponseValid(resItem)) {
        Severity: Major
        Found in libraries/precisoUtils/bidUtilsCommon.js and 1 other location - About 5 hrs to fix
        modules/appushBidAdapter.js on lines 174..186

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 141.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        export function getBidFloor(bid) {
  if (!isFn(bid.getFloor)) {
    return deepAccess(bid, 'params.bidFloor', 0);
  }
        Severity: Major
        Found in libraries/precisoUtils/bidUtilsCommon.js and 1 other location - About 2 hrs to fix
        modules/admixerBidAdapter.js on lines 125..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          if (isStr(bid.nurl) && bid.nurl !== '') {
    bid.nurl = bid.nurl.replace(/\${AUCTION_PRICE}/, cpm);
    triggerPixel(bid.nurl);
  }
        Severity: Major
        Found in libraries/precisoUtils/bidUtilsCommon.js and 1 other location - About 1 hr to fix
        src/utils.js on lines 1281..1287

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            const placement = {
      placementId: bid.params.placementId,
      bidId: bid.bidId,
      schain: bid.schain || {},
      bidfloor: getBidFloor(bid)
        Severity: Minor
        Found in libraries/precisoUtils/bidUtilsCommon.js and 1 other location - About 55 mins to fix
        modules/loganBidAdapter.js on lines 39..44

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          if (!bid.requestId || !bid.cpm || !bid.creativeId ||
        !bid.ttl || !bid.currency || !bid.meta) {
        Severity: Minor
        Found in libraries/precisoUtils/bidUtilsCommon.js and 1 other location - About 40 mins to fix
        modules/limelightDigitalBidAdapter.js on lines 21..21

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status