Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/adlooxAnalyticsAdapter.js

Summary

Maintainability
D
1 day
Test Coverage

Function url has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

analyticsAdapter.url = function(url, args, bid) {
  // utils.formatQS outputs PHP encoded querystrings... (╯°□°)╯ ┻━┻
  function a2qs(a) {
    // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent
    function fixedEncodeURIComponent(str) {
Severity: Minor
Found in modules/adlooxAnalyticsAdapter.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File adlooxAnalyticsAdapter.js has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * This module provides [Adloox]{@link https://www.adloox.com/} Analytics
 * The module will inject Adloox's verification JS tag alongside slot at bidWin
 * @module modules/adlooxAnalyticsAdapter
 */
Severity: Minor
Found in modules/adlooxAnalyticsAdapter.js - About 2 hrs to fix

    Function enableAnalytics has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    analyticsAdapter.enableAnalytics = function(config) {
  analyticsAdapter.context = null;

  logInfo(MODULE, 'config', config);
    Severity: Major
    Found in modules/adlooxAnalyticsAdapter.js - About 2 hrs to fix

      Function enableAnalytics has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      analyticsAdapter.enableAnalytics = function(config) {
  analyticsAdapter.context = null;

  logInfo(MODULE, 'config', config);
      Severity: Minor
      Found in modules/adlooxAnalyticsAdapter.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function url has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      analyticsAdapter.url = function(url, args, bid) {
  // utils.formatQS outputs PHP encoded querystrings... (╯°□°)╯ ┻━┻
  function a2qs(a) {
    // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent
    function fixedEncodeURIComponent(str) {
      Severity: Minor
      Found in modules/adlooxAnalyticsAdapter.js - About 1 hr to fix

        Function commandProcess has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function commandProcess(cid) {
  const { cmd, data, callback } = COMMAND_QUEUE[cid];

  logInfo(MODULE, 'command', cmd, data);
        Severity: Minor
        Found in modules/adlooxAnalyticsAdapter.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

              return;
          Severity: Major
          Found in modules/adlooxAnalyticsAdapter.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return;
            Severity: Major
            Found in modules/adlooxAnalyticsAdapter.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return;
              Severity: Major
              Found in modules/adlooxAnalyticsAdapter.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return;
                Severity: Major
                Found in modules/adlooxAnalyticsAdapter.js - About 30 mins to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                    if (!(config.options.js === undefined || isStr(config.options.js))) {
    logError(MODULE, 'invalid js options value');
    return;
  }
                  Severity: Minor
                  Found in modules/adlooxAnalyticsAdapter.js and 2 other locations - About 35 mins to fix
                  modules/adlooxAnalyticsAdapter.js on lines 111..114
                  modules/adlooxAnalyticsAdapter.js on lines 131..134

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                    if (!(config.options.toselector === undefined || isFn(config.options.toselector))) {
    logError(MODULE, 'invalid toselector options value');
    return;
  }
                  Severity: Minor
                  Found in modules/adlooxAnalyticsAdapter.js and 2 other locations - About 35 mins to fix
                  modules/adlooxAnalyticsAdapter.js on lines 107..110
                  modules/adlooxAnalyticsAdapter.js on lines 131..134

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                    if (!(config.options.params === undefined || isPlainObject(config.options.params))) {
    logError(MODULE, 'invalid params options value');
    return;
  }
                  Severity: Minor
                  Found in modules/adlooxAnalyticsAdapter.js and 2 other locations - About 35 mins to fix
                  modules/adlooxAnalyticsAdapter.js on lines 107..110
                  modules/adlooxAnalyticsAdapter.js on lines 111..114

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 46.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status