prebid/Prebid.js

View on GitHub
modules/adplusBidAdapter.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function createBidRequest has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createBidRequest(bid) {
  // Developer Params
  const {
    inventoryId,
    adUnitId,
Severity: Minor
Found in modules/adplusBidAdapter.js - About 1 hr to fix

    Function isBidRequestValid has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function isBidRequestValid(bid) {
      if (!bid) {
        utils.logError(BIDDER_CODE, 'bid, can not be empty', bid);
        return false;
      }
    Severity: Minor
    Found in modules/adplusBidAdapter.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

        return true;
      Severity: Major
      Found in modules/adplusBidAdapter.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return false;
        Severity: Major
        Found in modules/adplusBidAdapter.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            if (storage.cookiesAreEnabled()) {
              const expires = new Date(Date.now() + COOKIE_EXP).toISOString();
          
              storage.setCookie(SESSION_CODE, sid, expires);
            }
          Severity: Major
          Found in modules/adplusBidAdapter.js and 1 other location - About 1 hr to fix
          modules/insticatorBidAdapter.js on lines 76..79

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            if (!bid.params.adUnitId || typeof bid.params.adUnitId !== 'string') {
              utils.logError(
                BIDDER_CODE,
                'bid.params.adUnitId is missing or has wrong type.'
              );
          Severity: Minor
          Found in modules/adplusBidAdapter.js and 1 other location - About 45 mins to fix
          modules/adplusBidAdapter.js on lines 64..70

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            if (!bid.params.inventoryId || typeof bid.params.inventoryId !== 'string') {
              utils.logError(
                BIDDER_CODE,
                'bid.params.inventoryId is missing or has wrong type.'
              );
          Severity: Minor
          Found in modules/adplusBidAdapter.js and 1 other location - About 45 mins to fix
          modules/adplusBidAdapter.js on lines 56..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status