Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/amxBidAdapter.js

Summary

Maintainability
F
3 days
Test Coverage

File amxBidAdapter.js has 500 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { registerBidder } from '../src/adapters/bidderFactory.js';
import { BANNER, VIDEO } from '../src/mediaTypes.js';
import {
  _each,
  deepAccess,
Severity: Minor
Found in modules/amxBidAdapter.js - About 1 day to fix

    Function buildRequests has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      buildRequests(bidRequests, bidderRequest) {
    const loc = getLocation(bidderRequest);
    const tagId = deepAccess(bidRequests[0], 'params.tagId', null);
    const testMode = deepAccess(bidRequests[0], 'params.testMode', 0);
    const fbid =
    Severity: Major
    Found in modules/amxBidAdapter.js - About 2 hrs to fix

      Function onTimeout has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        onTimeout(timeoutData) {
    if (timeoutData == null || !timeoutData.length) {
      return;
    }
      Severity: Minor
      Found in modules/amxBidAdapter.js - About 1 hr to fix

        Function interpretResponse has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          interpretResponse(serverResponse, request) {
    const response = serverResponse.body;
    if (response == null || typeof response === 'string') {
      return [];
    }
        Severity: Minor
        Found in modules/amxBidAdapter.js - About 1 hr to fix

          Function getUserSyncs has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            getUserSyncs(
    syncOptions,
    serverResponses,
    gdprConsent,
    uspConsent,
          Severity: Minor
          Found in modules/amxBidAdapter.js - About 1 hr to fix

            Function convertRequest has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function convertRequest(bid) {
  const size = largestSize(bid.sizes, bid.mediaTypes) || [0, 0];
  const isVideoBid = bid.mediaType === VIDEO || VIDEO in bid.mediaTypes;
  const av = isVideoBid || size[1] > 100;
  const tid = deepAccess(bid, 'params.tagId');
            Severity: Minor
            Found in modules/amxBidAdapter.js - About 1 hr to fix

              Function buildRequests has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                buildRequests(bidRequests, bidderRequest) {
    const loc = getLocation(bidderRequest);
    const tagId = deepAccess(bidRequests[0], 'params.tagId', null);
    const testMode = deepAccess(bidRequests[0], 'params.testMode', 0);
    const fbid =
              Severity: Minor
              Found in modules/amxBidAdapter.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function events has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  const events = timeoutData.map((timeout) => {
      const params = timeout.params || {};
      const size = getTimeoutSize(timeout);
      const { domain, page, ref } =
        timeout.ortb2 != null && timeout.ortb2.site != null
              Severity: Minor
              Found in modules/amxBidAdapter.js - About 1 hr to fix

                Function getSyncSettings has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function getSyncSettings() {
  const syncConfig = config.getConfig('userSync');
  if (syncConfig == null) {
    return {
      d: 0,
                Severity: Minor
                Found in modules/amxBidAdapter.js - About 1 hr to fix

                  Function onTimeout has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                    onTimeout(timeoutData) {
    if (timeoutData == null || !timeoutData.length) {
      return;
    }
                  Severity: Minor
                  Found in modules/amxBidAdapter.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getUserSyncs has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      syncOptions,
    serverResponses,
    gdprConsent,
    uspConsent,
    gppConsent
                  Severity: Minor
                  Found in modules/amxBidAdapter.js - About 35 mins to fix

                    Function convertRequest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function convertRequest(bid) {
  const size = largestSize(bid.sizes, bid.mediaTypes) || [0, 0];
  const isVideoBid = bid.mediaType === VIDEO || VIDEO in bid.mediaTypes;
  const av = isVideoBid || size[1] > 100;
  const tid = deepAccess(bid, 'params.tagId');
                    Severity: Minor
                    Found in modules/amxBidAdapter.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getUserSyncs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      getUserSyncs(
    syncOptions,
    serverResponses,
    gdprConsent,
    uspConsent,
                    Severity: Minor
                    Found in modules/amxBidAdapter.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function isSyncEnabled has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function isSyncEnabled(syncConfigP, syncType) {
  if (syncConfigP == null) return false;

  const syncConfig = syncConfigP[syncType];
  if (syncConfig == null) {
                    Severity: Minor
                    Found in modules/amxBidAdapter.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    function getGpp(bidderRequest) {
  if (bidderRequest?.gppConsent != null) {
    return bidderRequest.gppConsent;
  }
                    Severity: Major
                    Found in modules/amxBidAdapter.js and 1 other location - About 1 hr to fix
                    modules/omsBidAdapter.js on lines 222..230

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 61.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      return {
    r: re.topmostLocation,
    t: re.reachedTop,
    l: re.numIframes,
    s: re.stack,
                    Severity: Minor
                    Found in modules/amxBidAdapter.js and 1 other location - About 35 mins to fix
                    modules/adqueryBidAdapter.js on lines 116..122

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status