Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/apstreamBidAdapter.js

Summary

Maintainability
F
3 days
Test Coverage

Function dsuModule has 231 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var dsuModule = (function() {
  'use strict';

  var DSU_KEY = 'apr_dsu';
  var DSU_VERSION_NUMBER = '1';
Severity: Major
Found in modules/apstreamBidAdapter.js - About 1 day to fix

    File apstreamBidAdapter.js has 425 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { generateUUID, deepAccess, createTrackPixelHtml, getDNT } from '../src/utils.js';
import { registerBidder } from '../src/adapters/bidderFactory.js';
import { config } from '../src/config.js';
import { getStorageManager } from '../src/storageManager.js';
import { convertOrtbRequestToProprietaryNative } from '../src/native.js';
    Severity: Minor
    Found in modules/apstreamBidAdapter.js - About 6 hrs to fix

      Function dsuModule has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
      Open

      var dsuModule = (function() {
  'use strict';

  var DSU_KEY = 'apr_dsu';
  var DSU_VERSION_NUMBER = '1';
      Severity: Minor
      Found in modules/apstreamBidAdapter.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function hash has 81 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function hash(key, m) {
    if (typeof m === 'string') {
      m = stringToU8(m);
    }
    var k0 = {
      Severity: Major
      Found in modules/apstreamBidAdapter.js - About 3 hrs to fix

        Function buildRequests has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function buildRequests(bidRequests, bidderRequest) {
  // convert Native ORTB definition to old-style prebid native definition
  bidRequests = convertOrtbRequestToProprietaryNative(bidRequests);
  const data = {
    med: encodeURIComponent(window.location.href),
        Severity: Minor
        Found in modules/apstreamBidAdapter.js - About 1 hr to fix

          Function getBids has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function getBids(bids) {
  const bidArr = bids.map(bid => {
    const bidId = bid.bidId;

    let mediaType = '';
          Severity: Minor
          Found in modules/apstreamBidAdapter.js - About 1 hr to fix

            Function getBids has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function getBids(bids) {
  const bidArr = bids.map(bid => {
    const bidId = bid.bidId;

    let mediaType = '';
            Severity: Minor
            Found in modules/apstreamBidAdapter.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  l: buf[3] << 24 | buf[2] << 16 | buf[1] << 8 | buf[0]
            Severity: Minor
            Found in modules/apstreamBidAdapter.js and 1 other location - About 30 mins to fix
            modules/apstreamBidAdapter.js on lines 148..148

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  h: buf[7] << 24 | buf[6] << 16 | buf[5] << 8 | buf[4],
            Severity: Minor
            Found in modules/apstreamBidAdapter.js and 1 other location - About 30 mins to fix
            modules/apstreamBidAdapter.js on lines 149..149

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status