Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/ccxBidAdapter.js

Summary

Maintainability
D
2 days
Test Coverage

Function _buildBid has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

function _buildBid (bid, bidderRequest) {
  let placement = {}
  placement.id = bid.bidId
  placement.secure = 1
Severity: Minor
Found in modules/ccxBidAdapter.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

  } else if (deepAccess(bid, 'mediaTypes.video') || deepAccess(bid, 'mediaType') === 'video') {
    placement.video = {}

    if (typeof sizes !== 'undefined') {
      if (isArray(sizes[0])) {
Severity: Critical
Found in modules/ccxBidAdapter.js - About 2 hrs to fix

    Function _buildBid has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function _buildBid (bid, bidderRequest) {
  let placement = {}
  placement.id = bid.bidId
  placement.secure = 1
    Severity: Minor
    Found in modules/ccxBidAdapter.js - About 1 hr to fix

      Function _validateSizes has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function _validateSizes (sizeObj, type) {
  if (!isArray(sizeObj) || typeof sizeObj[0] === 'undefined') {
    return false
  }
      Severity: Minor
      Found in modules/ccxBidAdapter.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function isBidRequestValid has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        isBidRequestValid: function (bid) {
    if (!deepAccess(bid, 'params.placementId')) {
      logWarn('placementId param is reqeuired.')
      return false
    }
      Severity: Minor
      Found in modules/ccxBidAdapter.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _validateSizes has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function _validateSizes (sizeObj, type) {
  if (!isArray(sizeObj) || typeof sizeObj[0] === 'undefined') {
    return false
  }
      Severity: Minor
      Found in modules/ccxBidAdapter.js - About 1 hr to fix

        Function buildRequests has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          buildRequests: function (validBidRequests, bidderRequest) {
    // check if validBidRequests is not empty
    if (validBidRequests.length > 0) {
      let requestBody = {}
      requestBody.imp = []
        Severity: Minor
        Found in modules/ccxBidAdapter.js - About 1 hr to fix

          Function isBidRequestValid has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            isBidRequestValid: function (bid) {
    if (!deepAccess(bid, 'params.placementId')) {
      logWarn('placementId param is reqeuired.')
      return false
    }
          Severity: Minor
          Found in modules/ccxBidAdapter.js - About 1 hr to fix

            Function buildRequests has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              buildRequests: function (validBidRequests, bidderRequest) {
    // check if validBidRequests is not empty
    if (validBidRequests.length > 0) {
      let requestBody = {}
      requestBody.imp = []
            Severity: Minor
            Found in modules/ccxBidAdapter.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

              return true
            Severity: Major
            Found in modules/ccxBidAdapter.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return false
              Severity: Major
              Found in modules/ccxBidAdapter.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (deepAccess(bid, 'mediaTypes.banner.sizes')) {
      let isValid = _validateSizes(bid.mediaTypes.banner.sizes, 'banner')
      if (!isValid) {
        logWarn('Bid sizes are invalid.')
      }
                Severity: Minor
                Found in modules/ccxBidAdapter.js and 1 other location - About 35 mins to fix
                modules/ccxBidAdapter.js on lines 161..176

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    } else if (deepAccess(bid, 'mediaTypes.video.playerSize')) {
      let isValid = _validateSizes(bid.mediaTypes.video.playerSize, 'video')
      if (!isValid) {
        logWarn('Bid sizes are invalid.')
      }
                Severity: Minor
                Found in modules/ccxBidAdapter.js and 1 other location - About 35 mins to fix
                modules/ccxBidAdapter.js on lines 155..176

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 6 locations. Consider refactoring.
                Open

                  if (bid.adomain && bid.adomain.length > 0) {
    resp.meta.advertiserDomains = bid.adomain;
  }
                Severity: Major
                Found in modules/ccxBidAdapter.js and 5 other locations - About 35 mins to fix
                modules/adpartnerBidAdapter.js on lines 117..119
                modules/ixBidAdapter.js on lines 493..495
                modules/outbrainBidAdapter.js on lines 215..217
                modules/telariaBidAdapter.js on lines 255..257
                modules/ttdBidAdapter.js on lines 489..491

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      _each(sizeObj, function (size) {
        if (!isArray(size) || (size.length !== 2)) {
          result = false
        }
      })
                Severity: Minor
                Found in modules/ccxBidAdapter.js and 1 other location - About 35 mins to fix
                modules/ccxBidAdapter.js on lines 44..48

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    _each(sizeObj, function (size) {
      if (!isArray(size) || (size.length !== 2)) {
        result = false
      }
    })
                Severity: Minor
                Found in modules/ccxBidAdapter.js and 1 other location - About 35 mins to fix
                modules/ccxBidAdapter.js on lines 56..60

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status