Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/connectIdSystem.js

Summary

Maintainability
D
2 days
Test Coverage

Function getId has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

  getId(config, consentData) {
    if (connectIdSubmodule.userHasOptedOut()) {
      return;
    }
    const params = config.params || {};
Severity: Minor
Found in modules/connectIdSystem.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getId has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  getId(config, consentData) {
    if (connectIdSubmodule.userHasOptedOut()) {
      return;
    }
    const params = config.params || {};
Severity: Major
Found in modules/connectIdSystem.js - About 4 hrs to fix

    File connectIdSystem.js has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * This module adds support for Yahoo ConnectID to the user ID module system.
 * The {@link module:modules/userId} module is required
 * @module modules/connectIdSystem
 * @requires module:modules/userId
    Severity: Minor
    Found in modules/connectIdSystem.js - About 2 hrs to fix

      Function resp has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const resp = function (callback) {
      const callbacks = {
        success: response => {
          let responseObj;
          if (response) {
      Severity: Minor
      Found in modules/connectIdSystem.js - About 1 hr to fix

        Function getIdFromLocalStorage has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        function getIdFromLocalStorage() {
  if (storage.localStorageIsEnabled()) {
    let storedIdData = storage.getDataFromLocalStorage(MODULE_NAME);
    if (storedIdData) {
      try {
        Severity: Minor
        Found in modules/connectIdSystem.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function success has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                success: response => {
          let responseObj;
          if (response) {
            try {
              responseObj = JSON.parse(response);
        Severity: Minor
        Found in modules/connectIdSystem.js - About 1 hr to fix

          Function setEtldPlusOneCookie has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function setEtldPlusOneCookie(key, value, expirationDate, hostname) {
  const subDomains = hostname.split('.');
  for (let i = 0; i < subDomains.length; ++i) {
    const domain = subDomains.slice(subDomains.length - i - 1, subDomains.length).join('.');
    try {
          Severity: Minor
          Found in modules/connectIdSystem.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              INPUT_PARAM_KEYS.forEach(key => {
      if (typeof params[key] != 'undefined') {
        data[key] = params[key];
      }
    });
          Severity: Major
          Found in modules/connectIdSystem.js and 2 other locations - About 40 mins to fix
          modules/bidwatchAnalyticsAdapter.js on lines 47..49
          modules/oxxionAnalyticsAdapter.js on lines 56..58

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status