Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/iqmBidAdapter.js

Summary

Maintainability
C
1 day
Test Coverage

Function isBidRequestValid has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  isBidRequestValid: function (bid) {
    const banner = deepAccess(bid, 'mediaTypes.banner');
    const videoMediaType = deepAccess(bid, 'mediaTypes.video');
    const context = deepAccess(bid, 'mediaTypes.video.context');
    if ((videoMediaType && context === INSTREAM)) {
Severity: Minor
Found in modules/iqmBidAdapter.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildRequests has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  buildRequests: function (validBidRequests, bidderRequest) {
    return validBidRequests.map(bid => {
      var finalRequest = {};
      let bidfloor = getBidIdParameter('bidfloor', bid.params);
Severity: Minor
Found in modules/iqmBidAdapter.js - About 1 hr to fix

    Function isBidRequestValid has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      isBidRequestValid: function (bid) {
    const banner = deepAccess(bid, 'mediaTypes.banner');
    const videoMediaType = deepAccess(bid, 'mediaTypes.video');
    const context = deepAccess(bid, 'mediaTypes.video.context');
    if ((videoMediaType && context === INSTREAM)) {
    Severity: Minor
    Found in modules/iqmBidAdapter.js - About 1 hr to fix

      Function interpretResponse has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        interpretResponse: function (serverResponse, bidRequest) {
    const bidResponses = [];
    serverResponse = serverResponse.body;
    if (serverResponse && isArray(serverResponse.seatbid)) {
      _each(serverResponse.seatbid, function (bidList) {
      Severity: Minor
      Found in modules/iqmBidAdapter.js - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

            if ((videoMediaType && context === INSTREAM)) {
      const videoBidderParams = deepAccess(bid, 'params.video', {});

      if (!Array.isArray(videoMediaType.playerSize)) {
        return false;
        Severity: Critical
        Found in modules/iqmBidAdapter.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                  return false;
          Severity: Major
          Found in modules/iqmBidAdapter.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return !!(bid && bid.params && bid.params.publisherId && bid.params.placementId);
            Severity: Major
            Found in modules/iqmBidAdapter.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return false;
              Severity: Major
              Found in modules/iqmBidAdapter.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return !!(bid && bid.params && bid.params.publisherId && bid.params.placementId);
                Severity: Major
                Found in modules/iqmBidAdapter.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return false;
                  Severity: Major
                  Found in modules/iqmBidAdapter.js - About 30 mins to fix

                    Function getDevice has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    let getDevice = function (bidparams) {
  const language = navigator.language ? 'language' : 'userLanguage';
  return {
    geo: bidparams.geo,
    h: screen.height,
                    Severity: Minor
                    Found in modules/iqmBidAdapter.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                      VIDEO_ORTB_PARAMS.forEach((param) => {
    if (videoParams.hasOwnProperty(param)) {
      video[param] = videoParams[param];
    }
  });
                    Severity: Minor
                    Found in modules/iqmBidAdapter.js and 1 other location - About 35 mins to fix
                    modules/jwplayerBidAdapter.js on lines 220..224

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status