Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/jwplayerVideoProvider.js

Summary

Maintainability
F
1 wk
Test Coverage

Function JWPlayerProvider has 413 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function JWPlayerProvider(config, jwplayer_, adState_, timeState_, callbackStorage_, utils, sharedUtils) {
  const jwplayer = jwplayer_;
  let player = null;
  let playerVersion = null;
  const playerConfig = config.playerConfig;
Severity: Major
Found in modules/jwplayerVideoProvider.js - About 2 days to fix

    File jwplayerVideoProvider.js has 698 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
  PROTOCOLS, API_FRAMEWORKS, VIDEO_MIME_TYPE, PLAYBACK_METHODS, PLACEMENT, VPAID_MIME_TYPE, AD_POSITION
} from '../libraries/video/constants/ortb.js';
import {
  SETUP_COMPLETE, SETUP_FAILED, DESTROYED, AD_REQUEST, AD_BREAK_START, AD_LOADED, AD_STARTED, AD_IMPRESSION, AD_PLAY,
    Severity: Major
    Found in modules/jwplayerVideoProvider.js - About 1 day to fix

      Function onEvent has 215 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function onEvent(externalEventName, callback, basePayload) {
    if (externalEventName === SETUP_COMPLETE) {
      setupCompleteCallbacks.push(callback);
      return;
    }
      Severity: Major
      Found in modules/jwplayerVideoProvider.js - About 1 day to fix

        Function JWPlayerProvider has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
        Open

        export function JWPlayerProvider(config, jwplayer_, adState_, timeState_, callbackStorage_, utils, sharedUtils) {
  const jwplayer = jwplayer_;
  let player = null;
  let playerVersion = null;
  const playerConfig = config.playerConfig;
        Severity: Minor
        Found in modules/jwplayerVideoProvider.js - About 1 day to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function adStateFactory has 66 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function adStateFactory() {
  const adState = Object.assign({}, stateFactory());

  function updateForEvent(event) {
    const updates = {
        Severity: Major
        Found in modules/jwplayerVideoProvider.js - About 2 hrs to fix

          Function getOrtbVideo has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function getOrtbVideo() {
    if (!player) {
      return;
    }
          Severity: Minor
          Found in modules/jwplayerVideoProvider.js - About 1 hr to fix

            Function getOrtbContent has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function getOrtbContent() {
    if (!player) {
      return;
    }
            Severity: Minor
            Found in modules/jwplayerVideoProvider.js - About 1 hr to fix

              Function updateForEvent has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                function updateForEvent(event) {
    const updates = {
      adTagUrl: event.tag,
      offset: event.adPosition,
      loadTime: event.timeLoading,
              Severity: Minor
              Found in modules/jwplayerVideoProvider.js - About 1 hr to fix

                Function getJwEvent has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  getJwEvent: function(eventName) {
    switch (eventName) {
      case SETUP_COMPLETE:
        return 'ready';
                Severity: Minor
                Found in modules/jwplayerVideoProvider.js - About 1 hr to fix

                  Function getJwConfig has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                    getJwConfig: function(config) {
    if (!config) {
      return;
    }
                  Severity: Minor
                  Found in modules/jwplayerVideoProvider.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getJwConfig has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    getJwConfig: function(config) {
    if (!config) {
      return;
    }
                  Severity: Minor
                  Found in modules/jwplayerVideoProvider.js - About 1 hr to fix

                    Function JWPlayerProvider has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    export function JWPlayerProvider(config, jwplayer_, adState_, timeState_, callbackStorage_, utils, sharedUtils) {
                    Severity: Major
                    Found in modules/jwplayerVideoProvider.js - About 50 mins to fix

                      Function adStateFactory has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      export function adStateFactory() {
  const adState = Object.assign({}, stateFactory());

  function updateForEvent(event) {
    const updates = {
                      Severity: Minor
                      Found in modules/jwplayerVideoProvider.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      export function timeStateFactory() {
  const timeState = Object.assign({}, stateFactory());

  function updateForEvent(event) {
    const { position, duration } = event;
                      Severity: Major
                      Found in modules/jwplayerVideoProvider.js and 1 other location - About 5 hrs to fix
                      modules/videojsVideoProvider.js on lines 838..863

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 154.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status